[WIP] Add Development section to README #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CamDavidsonPilon
approved these changes
Dec 23, 2018
|
Lgtm. The current lint failures still need to be fixed (and tested), tbd later |
|
Happy holidays @Kilo59! |
|
Whoops can’t merge over a phone. I will later this week :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a short section to readme explaining how to use the provided
Makefileto set up a dev environment, format their code and install/run thepre-commithooks.Other changes
blackhook, to prevent hook failure ifpython3.6is not present.lifelinesas an editable dependency dev-requirementdev-requirements.txttodoc-requirements.txtso the developer doesn't need to execute 2 separate commands to install them.