5 spinner loader on api calls #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt. Implemented interceptors for requests and response.
…pinner-loader-on-api-calls
|
Nice work on the Spinners! |
|
I'm so sorry! It's intended to be a finished work so I will review the code right away! |
|
There you go. There were some lint errors in the e2e tests. I needed to create a getter in the spinner-list test to solve a variable scoping problem. |
|
Great! Merging right away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
Implemented a default spinner component which covers the Vue-Admin Actions views during the requests. For the template I used the Vuetify component v-progress-circular in color green.
Implementation
Implemented in an isolated component which has a property of type Boolean to indicate whether the spinner should be displayed or not.
For the loading state, interceptors for the request and response were implemented. These interceptors commit an action which sets the isLoading state to true or false.
All the Action components use the same getter for the isLoading state to pass the value to the Spinner component.
Closes #5