-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback on failing authentication #188
Conversation
Why is this a WIP? I implemented a solution which requires the user to handle the asyn response from the authentication with a
I've thought about this solution but I don't really know if this is the right approach for this, however I could not find a better way. I've consider passing also the user, to resemble other libraries which, in similar cases, defines a callback like |
I also modified the response from the demo server to return 401 status when the user or password is incorrect. |
…return an async resource so the user can chain the authentication resultand handle the error response.
15f35c0
to
b009086
Compare
Not really sure what's going on. My guess is that the snackbar disappears before Cypress finally finds it in the virtual dom.
|
updates unit tests lib: generalises findButtonByName function
Keeps failing, even with a timeout of |
9cfd008
to
3326fe1
Compare
End to end tests for |
Description
This PR provides:
Closes #180
Type of change
How Has This Been Tested?
Apart from running all previous tests (unit/e2e) two different e2e tests were added. Those are
Checklist: