Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

210 the admin component ignores custom unauthorized layouts #211

Merged

Conversation

sgobotta
Copy link
Member

@sgobotta sgobotta commented Feb 9, 2020

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

This PR provides:

Fixes #210

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce the cases. Please also list any relevant details for your test configuration

  • Manual test

Instructions:

1. Use a custom layout in the authorized prop for the Admin component
2. Visit an anauthorized page

Expected result: The layout should be seen

Checklist:

The following options in bold are required for a PR approval. Please check the boxes only if necessary, it help us minimizing the reviewing process.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov-io
Copy link

codecov-io commented Feb 9, 2020

Codecov Report

Merging #211 into develop will increase coverage by 2.28%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #211      +/-   ##
===========================================
+ Coverage    42.24%   44.53%   +2.28%     
===========================================
  Files           94       94              
  Lines          748      750       +2     
  Branches        30       30              
===========================================
+ Hits           316      334      +18     
+ Misses         429      413      -16     
  Partials         3        3
Impacted Files Coverage Δ
src/components/Core/src/Core.vue 0% <ø> (ø) ⬆️
src/components/Admin/src/Composer.vue 0% <ø> (ø) ⬆️
src/components/Admin/src/defaults.js 100% <100%> (ø) ⬆️
src/components/Admin/src/Admin.vue 100% <100%> (ø) ⬆️
src/va-auth/src/store/modules/mutations.js 66.66% <0%> (+16.66%) ⬆️
src/va-auth/src/store/modules/getters.js 60% <0%> (+20%) ⬆️
src/va-auth/src/store/modules/actions.js 61.53% <0%> (+30.76%) ⬆️
src/components/Admin/src/Authenticated.vue 100% <0%> (+50%) ⬆️
src/components/Admin/src/Unauthenticated.vue 100% <0%> (+50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19a3f4e...607c3c3. Read the comment docs.

@sgobotta sgobotta merged commit b6059a6 into develop Feb 9, 2020
@sgobotta sgobotta deleted the 210-The-Admin-component-ignores-custom-unauthorized-layouts branch February 9, 2020 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants