Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

72 as a user i can declare actions as children of a resource component #73

Merged
merged 54 commits into from
Feb 4, 2019
Merged

72 as a user i can declare actions as children of a resource component #73

merged 54 commits into from
Feb 4, 2019

Conversation

sgobotta
Copy link
Member

@sgobotta sgobotta commented Jan 30, 2019 •
edited

This PR provides:

  • Support for writing Views for a Resource as components in the Vue template.
  • Resource component refactor
  • Composer components creation. A composer acts as a wrapper component for a Resource or a View (List, Show, Create, Edit). It's goal is to receive those properties meant to be sent to a component, pre-process them, and use them as the context of a new VNode. This VNode is created using the render callback params (createElement and context).
  • Refactored Resource unit test

Closes #72
Depdends on #70

@sgobotta
Adds a directories property with the documentation url
ad24a62
@sgobotta
Creates an error.messages constants file
cd60248
@sgobotta
Implements a handler for error throwing
9acc0a7
@sgobotta
Creates a defaults file that defines the Resource component initialis…
2812a5a 
…ation attributes:

+ A new alias is defined in vue.config.js and jest.config.js : @handlers
@sgobotta
Applies the new defaults to the Resource component
5758c20
@sgobotta
Resource Tests: Adds negative tests for invalid properties
ac94d14
@sgobotta
Package.json: installs Joi as the validation framework
e3f4e7c
@sgobotta
Implements a validators module with a first basic validation for redi…
acdacd6 
…rect Resource prop
@sgobotta
Implements a templates module with fixed error messages as json files
83df348
@sgobotta
Constants: error messages update
7bcf8b7 
+ The error constants now use the templates to build error messages
@sgobotta
Error Handler: implements a schema validation handler
7cfcb38
@sgobotta
Defaults for Resource: adds a validate function for the redirect prop…
4912ec8 
…erty
@sgobotta
Adds the redirect validation to the component property validator func…
6b3edd6 
…tion
@sgobotta
Adds new aliases for templates and validators packages
5af89f8
@sgobotta
Implements a test for invalid redirect property
9360538 
+ Adds aliases to jest.config
@sgobotta
Removed semicolons
0ffb46f
@sgobotta
Implements a composer as a wrapper of the Resource component
27eaad0
@sgobotta
Implements a Composer as a wrapper of the List action component
feaa6a9
@sgobotta
List: removes the ID header by default
7254377 
+ Renames some prop names
@sgobotta
Renames the resource.vue component to Resource.vue
e7ab718
@sgobotta
Resource: updates the binding utils to match the Resource requirements
b7d182c
@sgobotta
Creates a List Articles component for the demo App
ad8602c
@sgobotta
Updates the demo App with the new Articles List format
0a51d1d
@sgobotta
Updates the List composer to treat List as a parent of views or a com…
ad82f4d 
…ponent with an array of elements as props
@sgobotta
List Update: the component now accepts new fields for the table
9033db4
@sgobotta
Resource: the binding utils passes the new properties for the List
3f7ed22 
+ List of articles in demo was moved to an articles components directory
@sgobotta
Resource composer: refactored the return statement
51f7e66
@sgobotta
Resource unit test: fixes the Resource directory
3f17f34
@sgobotta
List composer: updates comments
b40a7c8
@sgobotta
App demo: renamed usage for the List component
c12ff5b
@sgobotta
Show component usage: syntax update
21b634d 
+ A user can now declare the show view as a component of a Resource slot
+ Implemented a composer for the core Show component
+ Updated the binding utils to send the right props to the user Show component
@sgobotta
Show core component: renamed prop 'name' to 'resourceName'
41a68a8
@sgobotta
Store Utils: renamed getEntity function to getEntityForm
7e1cf0c
@sgobotta
Store Utils: adds a fetchEntity function
7759b14 
+ Show core view has been refactored to use the fetchEntity function
+ Updated articlesList in the demo App
@sgobotta
Demo App Show: Fixes show to be used without an initialised store
4c1ee68
@sgobotta
Edit core component: updates
466b559 
+ A user can now define an Edit view as a child of Resource
+ An Edit component Composer has been implemented
+ Created new Edit component for the Articles App demo
+ Updated the edit binding utils
@sgobotta
Edit core component: renamed the 'name' prop to 'resourceName'
b5230e9
@sgobotta
Edit core component refactor:
2c35e07 
+ Refactored calls to the store using the store utils
@sgobotta
Create core component: updates and refactor
1b105f1 
+ Resource accepts Create components with fields declared in a template
+ Creates a new component for Articles creation
+ App uses the new component for the create slot
+ Refactors the binding utils in the create function
@sgobotta
Edit core component: refactors the 'name' property for 'resourceName'
299f198
@sgobotta
Binding utils: fixes the name prop for the resourceName prop in the c…
9aa9c47 
…reate utils
@sgobotta
Create core component: uses the store utils to gather resources/entit…
245526a 
…ies data

+ refactored the create function in the binding utils
@sgobotta
Renamed a few imports to use @Aliases
730cdf4
@sgobotta
Composers refactor
44bf7e3 
+ Creates a composer function inside Actions
+ Refactors the List, Show, Create and Edit Composers
@sgobotta
Refactors the Composers to use a single generic function
263b4f5
@sgobotta
Adds defaults modules for Create and List views
c801af7
@sgobotta
Creates defaults modules for the List, Show, Create and Edit views
7576c81
@sgobotta
compose module: refactors the function
4238492 
+ The compose functions for each view have been removed
@sgobotta
Updates the compose function comment
16f9e1e 
+ refactors the compose function usage, the 'view' property was removed
@sgobotta
Fixes conflicts and cypress status 500 requests issues
e7c45bb 
+ The edit and show tests have been updated to visit the view directly, without passing from list
+ va.fetchEntity function has been applied to the Magazines view components
+ The cypress server utils have been slightly modified to avoid status 500 errors
@sgobotta
Adds some comments and reorders a few component functions in Magazine…
626a993 
…s views
@sgobotta sgobotta mentioned this pull request Feb 2, 2019
Merged
@sgobotta sgobotta added this to Needs review in Current Tasks Feb 2, 2019
@estefi-prieto estefi-prieto merged commit b308d22 into develop Feb 4, 2019
Current Tasks automation moved this from Needs review to Done Feb 4, 2019
@sgobotta sgobotta deleted the 72-as-a-user-i-can-declare-actions-as-children-of-a-Resource-component branch February 4, 2019 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estefi-prieto estefi-prieto Awaiting requested review from estefi-prieto

Assignees
No one assigned
Labels
None yet
Projects
Current Tasks
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgobotta @estefi-prieto