Parallel efficiency in tallies #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tweaked chi to normalise itself if not otherwise done. Fixed an incorrect conditional in aceNeutronNuclide that was causing bounds checking to fail.
Added padding to tally vectors in memory and parallelised tally processing in memory and tally admin.
Tallies/scoreMemory_class.f90
Outdated
| call fatalError(Here,'Index '//numToChar(idx)//' is outside bounds of & | ||
| & memory with size '//numToChar(self % N)) | ||
| end if | ||
| !if( idx < 0_longInt .or. idx > self % N) then |
There was a problem hiding this comment.
Should we keep the check here?
Returned a commented out fatalError.
valeriaRaffuzzi
approved these changes
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few tweaks to tallies to efficiently process them in parallel and avoid false sharing of tally cache lines with some (parameterised) array padding. Closes #12