Bumps rspec to 3.0.0 (release) and fixes deprecation warnings #4

andypike · 2014-02-23T17:05:36Z

We are using cancan in a rails 4 project. When we upgraded to rspec 3.0.0.beta2 we got a few deprecation warnings from cancan. Upon investigation, cancan seems to be dead but we found that cancancan seemed to be the successor.

To fix the deprecation we bumped rspec to 3.0.0.beta2 and fixed all the deprecation warnings. All the specs pass and I'm currently using this branch in our rails 4 project (everything still green).

I'm not sure what the plan is for cancancan and rspec compatibility, but if you want to move to rspec 3, this is a good starting point for you.

Enjoy.

bryanrite · 2014-02-23T19:58:38Z

Thanks @andypike, I'm setting up Appraisal so I can properly test CanCanCan vs multiple versions of Rails, I'll do something similar using this for RSpec as well.

Thanks for your help!

ck3g · 2014-06-04T11:57:37Z

spec/cancan/ability_spec.rb

@@ -7,12 +7,12 @@

  it "is able to :read anything" do
    @ability.can :read, :all
-    expect(@ability.can?(:read, String)).to be_true
-    expect(@ability.can?(:read, 123)).to be_true
+    expect(@ability.can?(:read, String)).to be(true)


You could use be_truthy/be_falsey instead.
rspec/rspec-expectations#283

What do you think?

ck3g · 2014-06-04T11:58:36Z

As soon as RSpec 3.0 has been released http://rubygems.org/gems/rspec
👍 for this

bolshakov · 2014-06-06T06:59:26Z

Rspec 3.0 released

ck3g · 2014-06-11T09:57:36Z

cancancan.gemspec

@@ -17,7 +17,7 @@ Gem::Specification.new do |s|
  s.files        = Dir["{lib,spec}/**/*", "[A-Z]*", "init.rb"] - ["Gemfile.lock"]
  s.require_path = "lib"

-  s.add_development_dependency 'rspec', '~> 2.14'
+  s.add_development_dependency 'rspec', '~> 3.0.0.beta2'


You also could update to '~> 3.0.0'

jcoyne · 2014-06-11T17:01:34Z

👍

andypike · 2014-06-11T18:51:26Z

I'll update the PR and will push up for you shortly 😄

andypike · 2014-06-11T20:22:23Z

Actually, looking at master some of these changes have already made it in. Not sure if this PR is of much value. Should we close this?

ck3g · 2014-06-11T20:39:00Z

Nope. Most important changes doesn't exists in master:
https://github.com/CanCanCommunity/cancancan/blob/master/lib/cancan/matchers.rb#L15
https://github.com/CanCanCommunity/cancancan/blob/master/lib/cancan/matchers.rb#L19

andypike · 2014-06-11T21:13:35Z

OK 😄

I've merged upstream master and bumped rspec to the 3.0.0 release. All specs pass and no deprecation warnings. I've kept the be(true) in place where possible so the specs are more specific. If a spec used to use be_false but returns a falsey value (such as nil) then I've changed these to be_truthy or be_falsey.

Hope this is ok with everyone ✨ ❤️

jcoyne · 2014-06-11T21:25:04Z

@andypike Thanks! 🔆

bryanrite · 2014-06-11T22:46:33Z

Thanks so much for this! I haven't had a chance to look this over, but will it support be_able_to matchers for libs still on RSpec < 3 or do we need to add the aliases as was done in #10?

ersatzryan · 2014-06-18T10:59:51Z

Any word on this? Anything I can do to help?

andypike · 2014-06-18T15:43:30Z

I haven't had a chance to look at the be_able_to matchers as mentioned above. I can add the same aliases as in #10 if someone can confirm that's all we need. Thanks.

bryanrite · 2014-06-18T16:34:05Z

Sorry, I've been in the middle of a move to a new country and have been super busy. I should have time to take a look at this tomorrow, I know its needed by many.

bryanrite · 2014-06-24T12:50:50Z

Ok, I had to do a bit of tweaking to get backwards compatibility so i've merged this into #85... just waiting on Travis, but all looks good locally with both RSpec 2 and RSpec 3, so I'll merge this and release 1.8.3 today. Let me know if anyone has any issues!

jcoyne · 2014-06-24T16:06:59Z

I'm getting:

undefined method `failure_message_for_should' for class `RSpec::Matchers::DifferentiateBlockMethodTypes'

when using rspec 2.99.0 and cancancan 1.8.3. It works fine with cancan 1.8.2

when running a test like:

 it { should_not be_able_to(:update, asset) }

jcoyne · 2014-06-24T16:11:45Z

Perhaps we need to add:

  alias failure_message_for_should failure_message
  alias failure_message_for_should_not failure_message_when_negated

as was done in #10

bryanrite · 2014-06-24T16:14:32Z

Bah, I tried with RSpec 2.14 and 3.0, here must be something in their 2.99 'deprecation' release... Lemme have a quick look, and i'll pull 1.8.3

bryanrite · 2014-06-24T17:13:08Z

@jcoyne Do you mind testing against: feature/fix_rspec_299?

I've changed the way we detect the custom matcher error method, it works locally for me for RSpec 2.14, 2.99, and 3, but I'd like a second opinion.

jcoyne · 2014-06-24T18:29:51Z

@bryanrite I tested that branch. It works great. 👏

bryanrite · 2014-06-24T18:52:40Z

@jcoyne Thanks! Pushed 1.8.4

author Remo Fritzsche <remo.fritzsche@sitrox.com> 1612868567 +0100 committer Alessandro Rodi <coorasse@gmail.com> 1657114188 +0200 # This is a combination of 4 commits. # This is the 1st commit message: Preserve nil values as extra arguments # This is the commit message #2: Fix link (#744) # This is the commit message #3: Documentation fixes and improvements - fix typo, punctuations, and grammar - fix broken and misformatted links - fix code sample # This is the commit message #4: Format documentation/guides and fix linting issues The motivation of the changes is to make these documents neater when reading offline using a text or code editor. Reading the documentation offline is faster, and the source code is readily available for further learning. The changes do not affect the meaning of each documentation or instruction. The following changes were made: - remove extra and trailing spaces - add new lines to separate the title, explanation, code samples, etc - fix headings, links - specify code block language (bash, ruby) Updated Devise.md as exception is changed CanCan::Unathorized exception not exists anymore, CanCan::AccessDenied is used. Also added responses for different content types as a recommendation. Add support for non-hash conditions Co-authored-by: Juleffel <juleffel@protonmail.com> Improve ability checks with Hashes Add Ruby 3.0 and Ruby 3.1 to CI Drop ActiveRecord4 from CI (#778)

Bumps rspec to 3.0.0.beta2 and fixes deprecation warnings

0a20095

bryanrite mentioned this pull request Mar 5, 2014

Updated matchers to work with rspec 3.0.0 #10

Closed

bryanrite mentioned this pull request Apr 2, 2014

failure_message_for_should_not is deprecated. Use failure_message_when_negated` instead #38

Closed

ck3g reviewed Jun 4, 2014
View reviewed changes

ck3g reviewed Jun 11, 2014
View reviewed changes

Merged upstream master and bumped rspec to 3.0.0 (release)

531c017

andypike changed the title ~~Bumps rspec to 3.0.0.beta2 and fixes deprecation warnings~~ Bumps rspec to 3.0.0 (release) and fixes deprecation warnings Jun 11, 2014

bryanrite mentioned this pull request Jun 12, 2014

replaced deprecated methods for rspec #80

Closed

vendethiel mentioned this pull request Jun 13, 2014

Updates matchers for RSpec3 syntax #81

Closed

bryanrite mentioned this pull request Jun 24, 2014

Feature/rspec 3 #85

Merged

bryanrite closed this Jun 24, 2014

bryanrite mentioned this pull request Jun 24, 2014

Better detection of custom matcher for RSpec 2.99 #86

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bumps rspec to 3.0.0 (release) and fixes deprecation warnings #4

Bumps rspec to 3.0.0 (release) and fixes deprecation warnings #4

andypike commented Feb 23, 2014

bryanrite commented Feb 23, 2014

ck3g Jun 4, 2014

ck3g commented Jun 4, 2014

bolshakov commented Jun 6, 2014

ck3g Jun 11, 2014

jcoyne commented Jun 11, 2014

andypike commented Jun 11, 2014

andypike commented Jun 11, 2014

ck3g commented Jun 11, 2014

andypike commented Jun 11, 2014

jcoyne commented Jun 11, 2014

bryanrite commented Jun 11, 2014

ersatzryan commented Jun 18, 2014

andypike commented Jun 18, 2014

bryanrite commented Jun 18, 2014

bryanrite commented Jun 24, 2014

jcoyne commented Jun 24, 2014

jcoyne commented Jun 24, 2014

bryanrite commented Jun 24, 2014

bryanrite commented Jun 24, 2014

jcoyne commented Jun 24, 2014

bryanrite commented Jun 24, 2014

Bumps rspec to 3.0.0 (release) and fixes deprecation warnings #4

Bumps rspec to 3.0.0 (release) and fixes deprecation warnings #4

Conversation

andypike commented Feb 23, 2014

bryanrite commented Feb 23, 2014

ck3g Jun 4, 2014

Choose a reason for hiding this comment

ck3g commented Jun 4, 2014

bolshakov commented Jun 6, 2014

ck3g Jun 11, 2014

Choose a reason for hiding this comment

jcoyne commented Jun 11, 2014

andypike commented Jun 11, 2014

andypike commented Jun 11, 2014

ck3g commented Jun 11, 2014

andypike commented Jun 11, 2014

jcoyne commented Jun 11, 2014

bryanrite commented Jun 11, 2014

ersatzryan commented Jun 18, 2014

andypike commented Jun 18, 2014

bryanrite commented Jun 18, 2014

bryanrite commented Jun 24, 2014

jcoyne commented Jun 24, 2014

jcoyne commented Jun 24, 2014

bryanrite commented Jun 24, 2014

bryanrite commented Jun 24, 2014

jcoyne commented Jun 24, 2014

bryanrite commented Jun 24, 2014