Remove unnecessary call to resolve_column_aliases
#657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghiculescu
referenced
this pull request
in rails/rails
Oct 26, 2020
We now always use `arel_attribute` for attribute alias resolution.
ghiculescu
changed the title
resolve_column_aliases
ghiculescu
force-pushed
the
avoid-resolve_column_aliases-2
branch
from
c2d9066
to
1175f03
Compare
ghiculescu
force-pushed
the
avoid-resolve_column_aliases-2
branch
from
1175f03
to
c6e1426
Compare
|
man, travis is soooo backed up |
|
Hey! Any chance of pushing this forward? Rails 6.1.0.rc2 has been released and it would be awesome having a compatible CanCanCan version 🙏 |
coorasse
approved these changes
Dec 9, 2020
|
We should probably merge this now that 6.1 is live https://weblog.rubyonrails.org/2020/12/9/Rails-6-1-0-release/ since it's a blocker to upgrading. |
5 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #652. FYI @jules2689