Add Rails 6.1 support #3862
Merged
Add Rails 6.1 support #3862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@filippoliverani they both seem merged now. I'd wait for #3865 to be merged since at the moment that's the only way to have the CanonicalRails gem working with Rails 6.1. |
|
Looking good!! |
filippoliverani
force-pushed
the
filippoliverani/rails-master-support
branch
2 times, most recently
from
820f64f
to
3f5e638
Compare
Since rails/rails@7b39197 serialezable hash attributes are not allocated by default anymore if not used.
Since rails/rails@c53c4 rspec-activemodel-mocks is not compatible anymore with `ActiveRecord#has_attribute` inner implemementation, to work around that we can replace mocks with stubs where possibile.
Since rails/rails@65e42c9 `ActionController::Base#controller_name` is empty in test enviroment and must be explicitly subbed in Rspec.
Since rails/rails@4639318 `select` on joined tables has started to work correctly instead of returing all fields.
Since rails/rails@5411565 DidYouMean suggestions has been added to missing params errors in controllers, we have to remove them before using error messages in API error responses body.
filippoliverani
force-pushed
the
filippoliverani/rails-master-support
branch
from
3f5e638
to
1bdd18c
Compare
filippoliverani
force-pushed
the
filippoliverani/rails-master-support
branch
from
1bdd18c
to
8fb31ac
Compare
|
Awesome work! 👍 |
jarednorman
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3784
This PR fixes some incompatibilities with Rails 6.1:
rspec-activemodel-mockss mock_model is not compatible with some ActiveRecord associationshelpers specsselectin joins now always works correctlyDidYouMeansuggestionsTODO:
Checklist:
[ ] I have updated Guides and README accordingly to this change (if needed)[ ] I have added tests to cover this change (if needed)[ ] I have attached screenshots to this PR for visual changes (if needed)