Fix issue #254 #256
Merged
Fix issue #254 #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Larpoux Would you like to change the license? |
|
Oh, yesssssss! Pleeeeease. If you do not mind, of course. |
|
I dont mind with your opinion since u r the core contributor~ You can change the license in this PR with the readme! |
|
@Larpoux So how is this now? |
|
I sent a new PR #257 . I am currently working on Pause/Resume during recording. |
|
Thanks again for your concern 👍 So may I merge this without and changes in the license? |
|
Yes, I changed the license, because you told me that I may do it.
…On 30 Mar 2020 at 14:42 +0200, Hyo Chan Jang ***@***.***>, wrote:
Thanks again for your concern 👍 So may I merge this without and changes in the license?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Well but I can't see any changes in license in this PR. |
|
I changed the LICENSE file, and all the headers in the sources files.
(I hope ;-) )
…On 30 Mar 2020 at 14:52 +0200, Hyo Chan Jang ***@***.***>, wrote:
Well but I can't see any changes in license in this PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Above is only file changes I can see in this |
hyochan
pushed a commit
that referenced
this pull request
Apr 1, 2020
* OGG/OPUS support on iOS * Small fix in README * Small fix in README * Small modifications after Hyo review * A notice that ffmpeg needs a minSDK 24 or later, on Android * Throw an exception if the native plugin return an error, instead of trying to return an exception as a String * Compatibility with Flutter Embeded V2 * README : flutter_sound has depencie on permission_handler plugin * Merge with flutter_sound Master Branch * flutter_ffmpeg LTS Release - minAndroidSdk 16 (instead of 24) * removed .history. * added missing packages. * removed dependency that wasn't required. * removed unused import. * removed an unnecessary dependency. * removed warnings and unnecessary awaits. * removed unused import. * removed code generating warnings. * Just one example is enough. There are problems with flutter IDE when two app in the same plugin directory. * - There was a crash when calling onPlayerStateChanged and _playerController was null - StartPlayerFromBuffer tested _audioState too late - Do not throw an exception when calling stopPlayer and the Player is already stopped * There was a crash in onRecorderStateChanged when _recorderController was null. Return null now * Issue 213 * Do not throw an exception when startPlayer() and _audioState is not "IS_STOPPED". Just stop the player silently * Sound volume with device buttons * Audio Focus control * Flutter embedded V2 does not work * intermediate, before merging Salvatore * Flauto for iOS * Saving state before my vacations * Working on #227 * #227 fix * Delete unwanted objects * Working on Android * Notifications are shown on Android * Icon sur le lock-screen d android * Duck others on Android * Ready for a pull request to the Master branch * Icon on Android Example was incorrect. Now show the flutter_sound Logo * Track.albumArtAsset * Android < 26 must be supported * Fix a bug on the lock-screen between two songs : we want to kip canPause, canSkipForward and canSkipBackward * Protection when flutter_sound is called in a bad state * LGPL-3 * LGPL-3 * 3.0.0+2 * Readme * Add API verbs : getLastFFmpegReturnCode() and getLastFFmpegCommandOutput() * . * FlutterSound module is now split into FlautoRecorder and FlautoPlayer on iOS * FlutterSound module is now split into FlautoRecorder and FlautoPlayer on Android * Messages are correctly multiplexed on the 3 channels, on IOS * Messages are correctly multiplexed on the 3 channels, on Android * Messages are correctly multiplexed on the 3 channels, on Android * Example does not use any more deprecated interface * Ready for sa merge to flutter_sound master branch * pauseRecorder() and resumeRecorder() * Ready to merge with "beta" * Resolve conflict with dooboolab * Add pauseRecorder() and resumeRecorder() in flutter_sound compatibility module * flutter_sound is now compatible with permission_handler 5.x.x [#259] * flutterSound.duration() and flutterSound.FFmpegGetMediaInformation() * flutterSound.duration() and flutterSound.FFmpegGetMediaInformation() * CHANGELOG for 3.1.0 * CHANGELOG for 3.1.0 * CHANGELOG for 3.1.0 * xyz.canardoux.flauto -> com.dooboolab.flutter_sound - FlautoRecorder -> FlutterSoundRecorder - FlautoPlayer -> FlutterSoundPlayer * #254 #256 #260 * #254 #256 #260 * #254 #256 #260 * #242 * minSdk = 16 instead of 28 * #260 * Notice in README that pauseRecorder() and resumeRecorder on Android needs at least API24 * #242 : conflits in temporary files when several FlutterSoundRecorder and several FlutterSoundPlayer * Channels are com.dooboolab.flutter_sound_player, com.dooboolab.flutter_sound_recorder and com.dooboolab.flutter_sound_track_player * Seek player on iOS * Rename modules -> FlutterSoundPlayer and -> FlutterSoundRecorder * Check null exception to prevent throwing (null safe)' * Rename serviceSuccessConnectionCallback * Seek player correctly in TrackPlayer Co-authored-by: bsutton <bsutton@noojee.com.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will probably fix #254