added docker init for web container #41
Conversation
|
@jeffw16 please approve this PR. |
|
@PiyushRaj927 I'm sure you didn't mean this on purpose, but nobody's PR is entitled to approval. I am just a volunteer who works a full-time job who does code reviews in his free time. I'm not obligated to approve your PR or anyone's PR. Please kindly revisit your tone when asking for a code review. |
|
If you want to remind me to take a look, there's better ways of saying it. For instance: "@jeffw16 This PR is in tandem to the previous PR you just approved. Would you have some time to take a look at it? It's very important that this is also incorporated into the Docker Compose stack." By the way, thank you for tagging me. Just please kindly rephrase your request next time. |
|
@jeffw16, I apologize for my previous comment, it was not my intention to be disrespectful. |
This comment was marked as abuse.
This comment was marked as abuse.
|
It doesn't look like we have enough community or developer support to put this plan into action. Sorry, but we can't accept this PR at the moment. It's a shame, because I really would have liked to see it happen :( |
Related PR Canasta#222
This PR adds the docker init to the web container to manage Apache and php-fpm processes as discuussed in this comment.