Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wren-ui): Support edit view metadata mode #224

Merged
merged 7 commits into from
May 13, 2024
Merged

feat(wren-ui): Support edit view metadata mode #224

merged 7 commits into from
May 13, 2024

Conversation

fredalai
Copy link
Contributor

@fredalai fredalai commented May 9, 2024 •
edited

Description

  • Support edit view metadata mode

Tasks

  • Metadata drawer
    • display name as drawer title (model & view)
    • show view’s display name on the Name field
    • show view’s description
    • list all columns
      • column name - Name
      • column type - Type
      • column description - Description
  • Those allowed to update metadata are:
    • view (alias) name
    • view description
    • column description
  • API
    • update diagram API
    • add updateViewMetadata API
  • Support update view metadata & error handler

UI screenshots

截圖 2024-05-09 下午5 56 08

截圖 2024-05-09 下午5 56 12

截圖 2024-05-09 下午6 00 23

截圖 2024-05-09 下午6 00 26

@fredalai fredalai force-pushed the feature/edit-view-metadata branch 2 times, most recently from d380692 to 78d6b00 Compare May 9, 2024 10:03
@fredalai fredalai added module/ui UI related ci/ui labels May 9, 2024
@fredalai fredalai force-pushed the feature/edit-view-metadata branch from 78d6b00 to 81be916 Compare May 9, 2024 10:06
@fredalai fredalai marked this pull request as ready for review May 9, 2024 10:06
andreashimin
andreashimin approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@andreashimin andreashimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wwwy3y3
Copy link
Member

wwwy3y3 commented May 10, 2024

Wait for #228 merged to do some adjustments.

andreashimin
andreashimin approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@andreashimin andreashimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides a question, LGTM for 715c0fe

wren-ui/src/apollo/server/adaptors/wrenAIAdaptor.ts Outdated Show resolved Hide resolved
onlyjackfrost
onlyjackfrost approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@onlyjackfrost onlyjackfrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreashimin
Copy link
Contributor

Rebase to resolve conflicts with #230

@andreashimin andreashimin merged commit 60f45ce into main May 13, 2024
3 checks passed
@andreashimin andreashimin deleted the feature/edit-view-metadata branch May 13, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreashimin andreashimin andreashimin approved these changes

@onlyjackfrost onlyjackfrost onlyjackfrost approved these changes

@wwwy3y3 wwwy3y3 Awaiting requested review from wwwy3y3

Assignees
No one assigned
Labels
ci/ui module/ui UI related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fredalai @wwwy3y3 @andreashimin @onlyjackfrost