Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(wren-ui): Replace view, calculated field & relationship name to alias #230

Merged
merged 10 commits into from
May 13, 2024
Merged

chore(wren-ui): Replace view, calculated field & relationship name to alias #230

merged 10 commits into from
May 13, 2024

Conversation

andreashimin
Copy link
Contributor

@andreashimin andreashimin commented May 10, 2024 •
edited

Description

To replace view, calculated field & relationship reference name to alias name

Tasks

  • Replace view referenceName with displayName
  • Replace relationship referenceName to displayName
  • Provide relationship model & column displayName to client (BE)
  • Replace calculated field referenceName to displayName

@andreashimin andreashimin added the module/ui UI related label May 10, 2024
@andreashimin andreashimin changed the title chore(wren-ui): Replace view & relationship name to alias chore(wren-ui): Replace view, calculated field & relationship name to alias May 10, 2024
wwwy3y3
wwwy3y3 approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@wwwy3y3 wwwy3y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on backend

onlyjackfrost
onlyjackfrost approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@onlyjackfrost onlyjackfrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the Backend part

@wwwy3y3 wwwy3y3 merged commit 2fadf78 into main May 13, 2024
2 checks passed
@wwwy3y3 wwwy3y3 deleted the chore/column-alias branch May 13, 2024 07:30
@andreashimin andreashimin mentioned this pull request May 13, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wwwy3y3 wwwy3y3 wwwy3y3 approved these changes

@onlyjackfrost onlyjackfrost onlyjackfrost approved these changes

@fredalai fredalai Awaiting requested review from fredalai

Assignees
No one assigned
Labels
module/ui UI related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andreashimin @wwwy3y3 @onlyjackfrost