Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to delete the virtual bridge when multipassd shuts down #75

Closed
townsend2010 opened this issue Jan 26, 2018 · 1 comment
Closed
Assignees
Labels
Milestone

Comments

@townsend2010
Copy link
Contributor

townsend2010 commented Jan 26, 2018

It is possible to get into a situation where multipassd tries to use a different subnet than what the existing mpbr0 device is using. This mainly affects develops, but for correctness, the bridge should be removed when multipassd exits.

We should also clean up the routing and iptables when multipassd exits.

@townsend2010 townsend2010 self-assigned this Jan 26, 2018
@albaguirre
Copy link
Contributor

This also happens when someone switches from beta to edge channel when using the snap.

townsend2010 pushed a commit to townsend2010/multipass that referenced this issue Feb 12, 2018
@Saviq Saviq added this to the 2018.2.1 milestone Feb 21, 2018
albaguirre pushed a commit to albaguirre/multipass that referenced this issue Jun 22, 2018
Release 2018.2.1

- support JSON output in the CLI (canonical#65)
- switch to using a file socket for daemon-client IPC
- refactor ssh code and add unit tests for it
- switch to a patched libssh fork
  - improve mount performance (canonical#99)
- fix bash completion for mounts (canonical#40)
- wait for cloud-init on start (canonical#41)
- sanitize mount targets (canonical#17, canonical#47)
- support proxy configuratiion (canonical#53)
- default to a 5GB rootfs (canonical#29)
- randomize bridge subnet (canonical#49)
- fix a handful of mount bugs (canonical#71, canonical#64, canonical#78, canonical#77, canonical#83, canonical#82, canonical#81, canonical#104,
  canonical#105)
- add `--all` option to `info` (canonical#73)
- clean up networking on shutdown (canonical#75)
- set a 10s timeout for download progress (canonical#108)
- support rebooting instances (canonical#50)
- rename `connect` to `shell` to align with lxd (canonical#115)
Saviq added a commit that referenced this issue Feb 11, 2019
#75: hyper-v: Add support for saving and loading VM state a=townsend2010 r=Saviq
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants