Made the fish function implementation more idiomatic #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fish `br` function now uses fish best practices: - Lives in ~/.config/fish/functions/br.fish - Script written in more idiomatic fish style
This was referenced Jan 10, 2020
|
There should be a discussion with fish users on this PR. |
|
Totally. For reference, the relevant fish documentation for |
|
This is what I expect for fish shell integration. +1 from me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the fish function more idiomatic. In addition to a minor refactor of the function itself, to use more descriptive variable names and local variables, it also moves the function definition into
~/.config/fish/functions/br.fish, where fish stores & lazily loads functions from.Additionally,
rustfmt fish.rs