Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync broot working dir with current panel's root #814

Merged
merged 4 commits into from
Dec 30, 2023
Merged

Conversation

Canop
Copy link
Owner

@Canop Canop commented Dec 29, 2023

Fix #813

I'm not really sure there are many use cases for this, and I might gate it behind a configuration flag if I suspect there might be unwanted side effects.

@WizardUli
Copy link

I've tested this PR as requested in #813 (comment) and it seems to be working as expected.

  • When two tree panels are displayed the CWD is correctly synced to currently focused one.
  • When one of two panels is the staging area the CWD is correctly synced to the tree panel (focused or not).
  • Displaying help screen does not change the CWD as expected.

Can't think of any more possible edge-cases since I'm very new to broot.
Nice job! :)

@Canop Canop merged commit 9ba4200 into main Dec 30, 2023
1 check passed
@Canop Canop deleted the update-working-dir branch December 30, 2023 15:02
JonasLeonhard pushed a commit to JonasLeonhard/broot that referenced this pull request Jan 11, 2024
Sync broot working dir with current panel's root.
This feature is gated by the `update_work_dir` setting, but opt-out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep working directory of broot process in sync with directory of its currently focused panel
2 participants