Fix some 1D solver errors #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1103 +/- ##
=======================================
Coverage 73.49% 73.49%
=======================================
Files 364 364
Lines 47809 47808 -1
=======================================
Hits 35138 35138
+ Misses 12671 12670 -1
Continue to review full report at Codecov.
|
Fixed an error in the error handler for singular Jacobians where the wrong domain was being identified as containing the problematic row, that ultimately resulted in an integer divide by zero error instead of a CanteraError identifying which domain, grid point, and solution component the row corresponded to. This fixes a regression introduced in e8194af.
speth
force-pushed
the
fix-onedim-jac-error
branch
from
15e368a
to
7267fed
Compare
A reasonable initial guess for lambda can be obtained by noting the proportionality between lambda and rho*V**2 in the radial momentum equation. This fixes some cases where the correct solution involves large values of lambda and the initial guess of lambda = 0 was leading to singular Jacobians. See Cantera#1067
speth
force-pushed
the
fix-onedim-jac-error
branch
from
7267fed
to
f51f58a
Compare
speth
changed the title
This is analogous to the issue with multicomponent transport / Soret diffusion that was reported in Cantera#615 and fixed in Cantera#631.
speth
force-pushed
the
fix-onedim-jac-error
branch
from
8bb2141
to
f4dff38
Compare
ischoegl
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
CanteraErroridentifying which domain, grid point, and solution component the row corresponded to. This fixes a regression introduced in e8194af.FreeFlameIf applicable, fill in the issue number this pull request is fixing
Resolves #1067
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build&scons test) and unit tests address code coverage