New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Python examples to standard location #1352
Conversation
edf5edf
to
aaae492
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think setup.cfg.in
needs to remove the cantera.examples
module from package_data
, I think the cantera/examples/README.txt
will be included by a different setting there.
interfaces/cython/SConstruct
also can remove the dependency checks for */*/.py
e36aa02
to
03649d7
Compare
@bryanwweber - thanks for the prompt feedback! Finally figured out that |
f25e125
to
3fa0344
Compare
@bryanwweber … I put these checks back in as they should cover |
cda22be
to
4f34c31
Compare
Sorry, I didn't realize merging #1354 would create merge conflicts here (or maybe the conflicts were inevitable, regardless of the ordering?). |
4f34c31
to
c3e19f6
Compare
@speth ... no worries. Merge conflicts were inevitable - and are already fixed. None of the actual content changed (other than including |
c3e19f6
to
df535e7
Compare
df535e7
to
1c9de9c
Compare
Examples are now properly installed - I think this is ready now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ischoegl. This looks good to me.
Changes proposed in this pull request
Move Python examples to standard sample location, i.e.
samples/python
If applicable, fill in the issue number this pull request is fixing
Closes #1348
Checklist
scons build
&scons test
) and unit tests address code coverage