Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: Testing SCons 4.4.0 with multiple MSVC toolsets #1392

Closed
wants to merge 11 commits into from

Conversation

bryanwweber
Copy link
Member

Changes proposed in this pull request

If applicable, fill in the issue number this pull request is fixing

Closes #

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@ischoegl
Copy link
Member

@bryanwweber ... are you still working on this? Otherwise, I may take a stab ...

@bryanwweber
Copy link
Member Author

bryanwweber commented Oct 26, 2022

@ischoegl I'm not, I don't have a Windows machine to do rapid iterations, but the changes here should be a good start to what you need: https://github.com/Cantera/cantera/pull/1392/files#diff-d78c5c377c03dd251edc72cdb0ae7d9986fa08361eb392187218f8c670c0bc4eR170

Edit to add: I was trying to test and make sure that we got the correct behavior for SCons <4.4.0 when the new MSVC_TOOLSET_VERSION was introduced.

Feel free to close this if/when you push up a new branch 😄

@ischoegl ischoegl mentioned this pull request Nov 3, 2022
5 tasks
@bryanwweber
Copy link
Member Author

Superseded by #1404

@bryanwweber bryanwweber closed this Nov 3, 2022
@bryanwweber bryanwweber deleted the bryanwweber-patch-2 branch June 21, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants