Integrate SCons 4.4.0 MSVC options

[ischoegl]

Changes proposed in this pull request

• introduce msvc_toolset_version option

If applicable, fill in the issue number this pull request is fixing

Supersedes #1392

Addresses SCons/scons#3664

Checklist

• The pull request includes a clear description of this code change
• Commit messages have short titles and reference relevant issues
• Build passes (scons build & scons test) and unit tests address code coverage
• Style & formatting of contributed code follows contributing guidelines
• The pull request is ready for review

[codecov]

Codecov Report

Merging #1404 (78b9731) into main (f6744ec) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1404      +/-   ##
==========================================
+ Coverage   71.03%   71.06%   +0.03%     
==========================================
  Files         363      363              
  Lines       51855    51911      +56     
  Branches    17362    17374      +12     
==========================================
+ Hits        36834    36890      +56     
+ Misses      12676    12674       -2     
- Partials     2345     2347       +2     

Impacted Files	Coverage Δ
src/oneD/IonFlow.cpp	50.61% <0.00%> (-0.61%)	⬇️
src/zeroD/IdealGasMoleReactor.cpp	92.30% <0.00%> (-0.55%)	⬇️
src/zeroD/IdealGasConstPressureMoleReactor.cpp	73.22% <0.00%> (-0.38%)	⬇️
src/zeroD/Reactor.cpp	86.50% <0.00%> (-0.23%)	⬇️
src/equil/vcs_solve_TP.cpp	61.65% <0.00%> (-0.05%)	⬇️
src/equil/vcs_solve.cpp	66.14% <0.00%> (-0.04%)	⬇️
interfaces/cython/cantera/onedim.py	88.22% <0.00%> (-0.02%)	⬇️
include/cantera/oneD/StFlow.h	94.64% <0.00%> (ø)
interfaces/cython/cantera/_onedim.pyx	79.40% <0.00%> (+0.42%)	⬆️
src/oneD/Boundary1D.cpp	54.40% <0.00%> (+0.55%)	⬆️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[ischoegl]

@bryanwweber .. so this runs through (caveat: unrelated upstream macOS issues, which will probably resolve themselves): there was only a trivial glitch left in #1392 (simple key error).

Using both SCons 4.3.0 and 4.4.0, I tried messing with the tool set versions on my local MSVC installation. Kicking out 14.2 from installed MSVC tools makes the version unavailable (I no longer have VS 2019). Tests show that I can still use the 14.2 toolset for the 14.3 version, which I assume to be the correct behavior.

[bryanwweber]

Thanks for taking this! Just one question.

[bryanwweber]

Any idea about the Mac os failures?

[ischoegl]

Any idea about the Mac os failures?

Not really. Things compile fine on my M2 ... I think it's a temporary upstream issue with the toolchain?

Loading library to get build settings and version: libhdf5.dylib
      error: Unable to load dependency HDF5, make sure HDF5 is installed properly
      error: dlopen(libhdf5.dylib, 6): image not found

[bryanwweber]

Yeah that's a very strange error. I'm hesitant to merge with those failing though.

[ischoegl]

Yeah that's a very strange error. I'm hesitant to merge with those failing though.

We have the same failure on #1401 (merged - see https://github.com/Cantera/cantera/actions/runs/3390365384) so it’s definitely not due to anything we’re doing here.

[bryanwweber]

I can't merge for some reason, some authentication thing on my phone. Please go ahead!