Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate magic numbers in zeroD CLIB #660

Merged
merged 2 commits into from Aug 1, 2019
Merged

Deprecate magic numbers in zeroD CLIB #660

merged 2 commits into from Aug 1, 2019

Commits on Jul 31, 2019

  1. Update AUTHORS list

    @ischoegl
    Ingmar Schoegl authored and ischoegl committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    66244f9 View commit details
    Browse the repository at this point in the history

  2. [Reactor] Deprecating magic numbers. 

     * add deprecation warning for int ReactorBase::type() (to be changed after Cantera 2.5)
 * introduce temporary std::string ReactorBase::typeStr() (to be renamed after Cantera 2.5)
 * deprecate all functions using the old call and introduce associated temporary functions
    @ischoegl
    Ingmar Schoegl authored and ischoegl committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    5ed11a4 View commit details
    Browse the repository at this point in the history