check if plugin is configured #145
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
| const files = fs.readdirSync(dirPath); | ||
| let found = false; | ||
|
|
||
| files.forEach((file) => { |
There was a problem hiding this comment.
This will iterate over all files in the package. Using some will break the loop once a file with the search string was found.
|
|
||
| const searchInFile = (filePath: string, searchString: string) => { | ||
| const content = fs.readFileSync(filePath, "utf8"); | ||
| return content.includes(searchString); |
There was a problem hiding this comment.
This will also find the searchString if it is in a comment (and therefore never executed). I believe a more sophisticated approach is needed here like a regex. Keep in mind that it could be a line comment (//), a multiline comment (/*) or even a jsdoc comment (/**).
There was a problem hiding this comment.
Comments are stripped out in the build process, the upload command uploads your dist folder not source
There was a problem hiding this comment.
Not everyone uses a build process that removes all comments. And especially in debug builds comments have a valid use case.
cap.mp4
/claim #144