fix: users for alias not balanced across threads #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required due to the fact that, if tests are running with process or AppDomain isolation, all of the tests will cycle through the users in the same order. Shuffling the enumerators is an approximation that saves having to find a way to synchronise between AppDomains or processes.
ewingjm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
If tests are running with process or AppDomain isolation then all of the test threads will cycle individually through the users in the same order. This can lead to API limits be still being reached despite configuring many different users for an alias - this is due to the fact that tests are only load balanced within a thread rather than across threads.
Approach
Shuffling the enumerators is an approximation that saves having to find a way to synchronise between AppDomains or processes.
TODOs