Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected a problem with siblingsId throwing an IndexError #200

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

sonofmun
Copy link
Contributor

An example of when this error is thrown can be seen in the test that I have added.
What is happening here is that the range_length is 7, end is 7, and len(document_reference) is 14. That means that end + range_length == len(document_references). That means that the elif statement does not fire and it goes to else, which errors because it tries to call document_references[end + range_length], which would be document_references[14], which doesn't exist. This change should correct the problem.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.116% when pulling a70eb96 on correction_siblingsId into 3ff0f27 on dev.

@PonteIneptique
Copy link
Member

Sorry for the delay !

@PonteIneptique PonteIneptique merged commit 30123cd into dev Dec 9, 2019
@sonofmun sonofmun deleted the correction_siblingsId branch December 16, 2019 15:17
jacobwegner added a commit to scaife-viewer/MyCapytain that referenced this pull request May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants