Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Add data as json #5

Merged
merged 3 commits into from
Oct 1, 2021
Merged

WIP: Add data as json #5

merged 3 commits into from
Oct 1, 2021

Conversation

RAlanWright
Copy link
Contributor

@RAlanWright RAlanWright commented Oct 1, 2021 •
edited
Loading

  • Grab csv from Google Docs
  • Convert csv to json
  • Doublecheck json is correctly structured
  • Change fields to 1 word
  • ?

xanderyzwich
xanderyzwich approved these changes Oct 1, 2021
View reviewed changes
Copy link

@xanderyzwich xanderyzwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it does the job

@xanderyzwich
Copy link

closes #1

@RAlanWright
Copy link
Contributor Author

@xanderyzwich @Capocaccia Should we create a separate issue solely for getting this static data in, rather than closing #1 which includes 2 other things?

Kaytal
Kaytal approved these changes Oct 1, 2021
View reviewed changes
Copy link

@Kaytal Kaytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good straight data to JSON migration. In the future (and maybe I'll open an issue for it) we should probably structure this differently... Just food for thought.

Capocaccia
Capocaccia approved these changes Oct 1, 2021
View reviewed changes
src/App.tsx Outdated
// Testing data output
const SalaryData = require('./data/MemtechSalaryData.json');

console.log(SalaryData);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove console log please.

@Capocaccia Capocaccia merged commit 440316f into Capocaccia:main Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kaytal Kaytal Kaytal approved these changes

@xanderyzwich xanderyzwich xanderyzwich approved these changes

@Capocaccia Capocaccia Capocaccia approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RAlanWright @xanderyzwich @Kaytal @Capocaccia