Add ability to login using email or username alike #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Betree
requested changes
Oct 14, 2018
There was a problem hiding this comment.
Hey @adri thanks again! You made a good choice keeping the API as is, it will reduce the complexity of implementing the frontend.
Beside the confusion between name and username fields, I have nothing more to add to this PR. Good job 😉
| def get_user_for_email_or_name_password(email_or_name, password) do | ||
| user = | ||
| User | ||
| |> where([u], u.email == ^email_or_name or u.name == ^email_or_name) |
There was a problem hiding this comment.
User schema fields may be confusing. name is meant to store User's real name and is optional. The field you're looking for is u.username which is not nullable and unique among users.
There was a problem hiding this comment.
Ooops good one. Thanks! Fixed :)
To avoid complexity in the frontend, the email field is used for logging in with email or username.
adri
force-pushed
the
feature/login-with-user-name
branch
from
398fd4f
to
addbe03
Compare
Betree
approved these changes
Oct 14, 2018
Betree
added a commit
to CaptainFact/captain-fact-frontend
that referenced
this pull request
Oct 24, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid complexity in the frontend, the
emailfield is used forlogging in with email or username.
Fixes #9.