-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
10 statements out of videos #309
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Betree
reviewed
Mar 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good, nice job with your first contribution to the API @vguen! And sorry for the very late review...
Apart from the feedback below, you'll need to run mix format
to make the linter happy.
Statements are empty for now.
This allow to decouple comments from video
06178a3
to
cf1173b
Compare
cf1173b
to
dd4bcda
Compare
Betree
added a commit
that referenced
this pull request
Sep 29, 2021
* chore(deps): bump guardian_db from 2.0.3 to 2.1.0 Bumps [guardian_db](https://github.com/ueberauth/guardian_db) from 2.0.3 to 2.1.0. - [Release notes](https://github.com/ueberauth/guardian_db/releases) - [Changelog](https://github.com/ueberauth/guardian_db/blob/master/CHANGELOG.md) - [Commits](ueberauth/guardian_db@v2.0.3...v2.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * chore(deps): bump atomex from 0.3.0 to 0.4.1 Bumps [atomex](https://github.com/Betree/atomex) from 0.3.0 to 0.4.1. - [Release notes](https://github.com/Betree/atomex/releases) - [Changelog](https://github.com/Betree/atomex/blob/master/CHANGELOG.md) - [Commits](https://github.com/Betree/atomex/commits/0.4.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Updated readme status badges * chore(deps): bump ecto_sql from 3.5.4 to 3.6.0 Bumps [ecto_sql](https://github.com/elixir-ecto/ecto_sql) from 3.5.4 to 3.6.0. - [Release notes](https://github.com/elixir-ecto/ecto_sql/releases) - [Changelog](https://github.com/elixir-ecto/ecto_sql/blob/master/CHANGELOG.md) - [Commits](https://github.com/elixir-ecto/ecto_sql/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * 10 statements out of videos (#309) * Add graphql api to request (empty) statements Statements are empty for now. * Query statements * Add rest API route to query comments through statement This allow to decouple comments from video * Add filters on Statement.query_list * Add video field in graphql statement object * Remove commented code * Remove work on statement rest api * fix(statements): iterate on feedback * Add speaker_id filter to statements * fix(StatementsQuery): usage with null + simplify Co-authored-by: Benjamin Piouffle <benjamin@opencollective.com> * Create Dependabot config file (#329) Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * feat: Add reputation changes to user actions (#350) * fix(Actions): compute_reputation query (#363) * Reputation changes in activity log (#366) * feat: Reputation changes in activity log * enhancement(ActivityLog): Ignore self actions in :target * enhancement: Insert revert action when reversing vote (#367) Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Wid-Gaël Destin <wid.destin@gmail.com> Co-authored-by: vguen <v.guennou7@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a graphql backend for querying statements
Part of CaptainFact/captain-fact#10