Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10 statements out of videos #309

Merged
merged 10 commits into from
Jun 19, 2021
Merged

10 statements out of videos #309

merged 10 commits into from
Jun 19, 2021

Conversation

vguen
Copy link
Contributor

@vguen vguen commented Mar 16, 2021

Add a graphql backend for querying statements

Part of CaptainFact/captain-fact#10

Copy link
Member

@Betree Betree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good, nice job with your first contribution to the API @vguen! And sorry for the very late review...

Apart from the feedback below, you'll need to run mix format to make the linter happy.

apps/db/lib/db_schema/statement.ex Outdated Show resolved Hide resolved
apps/cf_graphql/lib/schema/types/statement.ex Outdated Show resolved Hide resolved
apps/db/lib/db_schema/statement.ex Outdated Show resolved Hide resolved
apps/cf/lib/comments/comments.ex Outdated Show resolved Hide resolved
apps/db/lib/db_schema/statement.ex Outdated Show resolved Hide resolved
@Betree Betree force-pushed the 10_statements_out_of_videos branch from 06178a3 to cf1173b Compare June 19, 2021 12:28
@Betree Betree force-pushed the 10_statements_out_of_videos branch from cf1173b to dd4bcda Compare June 19, 2021 12:29
@Betree Betree merged commit 7aa3daa into staging Jun 19, 2021
@Betree Betree deleted the 10_statements_out_of_videos branch June 19, 2021 12:47
Betree added a commit that referenced this pull request Sep 29, 2021
* chore(deps): bump guardian_db from 2.0.3 to 2.1.0

Bumps [guardian_db](https://github.com/ueberauth/guardian_db) from 2.0.3 to 2.1.0.
- [Release notes](https://github.com/ueberauth/guardian_db/releases)
- [Changelog](https://github.com/ueberauth/guardian_db/blob/master/CHANGELOG.md)
- [Commits](ueberauth/guardian_db@v2.0.3...v2.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* chore(deps): bump atomex from 0.3.0 to 0.4.1

Bumps [atomex](https://github.com/Betree/atomex) from 0.3.0 to 0.4.1.
- [Release notes](https://github.com/Betree/atomex/releases)
- [Changelog](https://github.com/Betree/atomex/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Betree/atomex/commits/0.4.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Updated readme status badges

* chore(deps): bump ecto_sql from 3.5.4 to 3.6.0

Bumps [ecto_sql](https://github.com/elixir-ecto/ecto_sql) from 3.5.4 to 3.6.0.
- [Release notes](https://github.com/elixir-ecto/ecto_sql/releases)
- [Changelog](https://github.com/elixir-ecto/ecto_sql/blob/master/CHANGELOG.md)
- [Commits](https://github.com/elixir-ecto/ecto_sql/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* 10 statements out of videos (#309)

* Add graphql api to request (empty) statements

Statements are empty for now.

* Query statements

* Add rest API route to query comments through statement

This allow to decouple comments from video

* Add filters on Statement.query_list

* Add video field in graphql statement object

* Remove commented code

* Remove work on statement rest api

* fix(statements): iterate on feedback

* Add speaker_id filter to statements

* fix(StatementsQuery): usage with null + simplify

Co-authored-by: Benjamin Piouffle <benjamin@opencollective.com>

* Create Dependabot config file (#329)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* feat: Add reputation changes to user actions (#350)

* fix(Actions): compute_reputation query (#363)

* Reputation changes in activity log (#366)

* feat: Reputation changes in activity log

* enhancement(ActivityLog): Ignore self actions in :target

* enhancement: Insert revert action when reversing vote (#367)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Wid-Gaël Destin <wid.destin@gmail.com>
Co-authored-by: vguen <v.guennou7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants