Make comment's actions more visible #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-leclercq
requested changes
Jul 31, 2018
| } | ||
| { replies && this.renderAction( |
There was a problem hiding this comment.
maybe this renderAction call could be extract of the JSX code,
there is (too) much (?) logic in it
| @@ -173,7 +179,7 @@ export class CommentDisplay extends React.PureComponent { | |||
|
|
|||
| actionReply() { | |||
| if (!this.ensureAuthenticated()) | |||
| return | |||
| return null | |||
There was a problem hiding this comment.
not quite fan but this is not core of this PR so nevermind
There was a problem hiding this comment.
Actually this is the practice recommended by React : https://reactjs.org/docs/conditional-rendering.html#preventing-component-from-rendering
There was a problem hiding this comment.
Returning null is still better than returning undefined
Manu1400
approved these changes
Jul 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After