Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip on AddVideo when not enough reputation #190

Merged
merged 3 commits into from
Aug 17, 2018

Conversation

Betree
Copy link
Member

@Betree Betree commented Aug 14, 2018

Preview

Trello

Important changes notes

Previously #sidebar and #main-container were two columns. Overflow on <body> was disabled and we were instead putting the overflow-y: auto on #main-container.

But a lot of libraries listen for scroll event on body to adapt their behavior. This is the case with the newly installed library react-popup and this needed to be changed to avoid having tooltips not following the scroll and being blocked in the middle of the screen.

Sidebar is now displayed with position: fixed and #main-container width set to calc(100% - ${sidebar_width}).

This may also improve #72.

@Betree Betree added UI / UX Everything related to the UX or UI feature New features labels Aug 14, 2018
@Betree Betree added this to the 0.8 milestone Aug 14, 2018
@Betree Betree merged commit 0d7199d into staging Aug 17, 2018
@Betree Betree mentioned this pull request Aug 18, 2018
@Betree Betree deleted the feature/add-video-reputation-guard-tooltip branch September 3, 2018 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New features UI / UX Everything related to the UX or UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant