Merging yellow doors will now combine them to remove duplicate connec… #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrimer
approved these changes
Oct 31, 2020
DRODLib/OrbUtil.cpp
Outdated
|
|
||
| #include "OrbUtil.h" | ||
|
|
||
| void GetOrbConnections(CDbRoom& room, CCoordSet doorCoords, vector<COrbData*>& outOrbData) { |
There was a problem hiding this comment.
Performance optimization: Make doorCoords a const reference, i.e., const CCoordSet& doorCoords. This avoids making a copy in calling the function, rather referencing the source object.
Same in next function.
There was a problem hiding this comment.
Still should make it a reference.
I.e., add '&' to avoid making a copy
There was a problem hiding this comment.
Sorry, I thought I did but I must've missed it
EvidentlyCube
force-pushed
the
merging-yellow-doors
branch
from
bc1c109
to
2cbaeb3
Compare
|
Try now! |
…tions and resolve conflicts by converting them to toggle
EvidentlyCube
force-pushed
the
merging-yellow-doors
branch
from
2cbaeb3
to
8cef282
Compare
|
Let's try again. |
mrimer
approved these changes
Nov 1, 2020
mrimer
added a commit
to mrimer/drod
that referenced
this pull request
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tions and resolve conflicts by converting them to toggle
Relevant thread