RPG: Fix regression in smooth lighting animation on moving pit platforms. Other lighting fixes and improvements. #331
Conversation
Rename DrawTLayer to DrawPlatformsAndTLayer.
…ghting on moving pit platforms.
…occluding area of northern-facing walls situated to either side of light source.
…rendering details related to height.
…of wall when cutting the corner of a northern wall.
|
Seems fine, I think I'll have to see it migrated to DROD codebase to better understand all the changes. |
|
I am reviewing it though! That was just first impression comment! |
There was a problem hiding this comment.
Approving but I'd like a few more comments where I mentioned it. I think I get now how it's supposed to work, though I do worry a little bit that it's a very specific solution, and if we ever end up needing something similar for anything else it'll be a lot of work to make it work. But then again I think it's high time to get 5.1.1 out the door, let's avoid refactor creep.
This is a good call out, and I don't disagree. This was a fair amount of work, and it is a specific solution. Still, we might find the new routine in CBitmapManager to be something that can be recycled for future complex rendering operations, even if we stop using it for this particular use case. Fortunately, my solution to fixing the pit darkening is localized to one spot in CRoomWidget, so it would be easy to remove. If we need to generalize this type of operation (or go with something completely different) in the future, I have no qualms (in principle) about ripping that out and replacing it. I agree we should get 5.1.1 out the door. |
|
BTW, to check out the light rendering changes, they are easiest to observe if you slow down the key repeat rate and try moving around in a very dark room. Try also stepping down from a wall or top of a door for z-axis light tweening! This will also all work when migrated to 5.x. |
|
Ready to review my latest commit. |
…pplied to entities.
Fix regression introduced in PR #331: too much darkness applied to entities.
Relevant topic
Multiple changes here. Check out the commit diffs individually for the recommended way to follow the changes.
If this looks good to you, I'll migrate these fixes to 5.1.1.