RPG: Correct errors in clipping logic and light application for sprites moving across room boundary. #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es moving into/out of room edge.
|
I'll start migrating these changes to 5.1.1 now. |
EvidentlyCube
approved these changes
Nov 17, 2020
mrimer
added a commit
to mrimer/drod
that referenced
this pull request
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant topic
There were multiple issues with the clipping and lighting logic at the room boundary. These changes are much easier to see with the larger tiles of RPG.
Once reviewed and approved, I can migrate these changes to 5.x.