Don't mark killed invisible NPCs as dead #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of memory improvements (#156), invisible NPCs are killed when their script runs an end command. However, marking them as dead means they are no longer valid speakers, leading to any speech they would speak being skipped. This is a regression, as previously invisible NPCs would be able to talk, even if their script had ended.
To fix this, I changed the
KillInvisibleCharacterfunction to not mark the killed NPC as dead. It is still moved to the dead monsters list, meaning it will no longer be processed, but it will retain its ability to be a speaker.See thread: https://forum.caravelgames.com/viewtopic.php?TopicID=45732