-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geyser-Fabric mod seems to break some Plugins loading #139
Comments
Geyser-Fabric was the first fabric mod someone in our team had worked on so its likely got a few issues. A PR to fix these would be appreciated. @Camotoy will likely expand upon this as he did most of the work on our Fabric mod. |
Yeah, that's my first foray into both Gradle and Fabric! I'll try to take a stab at fixing this, though. |
Incase it may be helpful, here's how I fixed Cardboard including ASM: |
Thanks for the link! Ideally this is fixed with GeyserMC/Geyser-Fabric@1bcbf3f. |
Unfortunately ASM seems to still be there.
|
Yeah, I've been working on that. Any form of exclusion isn't working, but the relocating definitely does. I'll push a build that does that now, but since I assume the dependency is unneeded in Fabric, I'd like to remove it entirely. Is that other dependency also highly recommended to be relocated? |
I don't think YAML needs to be relocated, I just included it as an example. |
This should be fixed. |
Error:
[18:11:26] [Server thread/FATAL]: Could not load 'plugins\LuckPerms-Bukkit-5.2.78.jar' in folder 'plugins'
org.bukkit.plugin.InvalidPluginException: java.lang.VerifyError: Bad type on operand stack
Exception Details:
Location:
org/bukkit/craftbukkit/util/Commodore.convert([BZLjava/lang/String;)[B @34: invokevirtual
Reason:
Type 'org/objectweb/asm/tree/ClassNode' (current frame, stack[1]) is not assignable to 'org/objectweb/asm/ClassVisitor'
Current Frame:
bci: @34
flags: { }
locals: { '[B', integer, 'java/lang/String', 'org/objectweb/asm/tree/ClassNode', 'org/objectweb/asm/ClassReader', 'org/objectweb/asm/ClassWriter' }
stack: { 'org/objectweb/asm/ClassReader', 'org/objectweb/asm/tree/ClassNode', integer }
Bytecode:
0x0000000: bb00 1e59 b700 1f4e bb00 2159 2ab7 0024
0x0000010: 3a04 bb00 2659 1904 03b7 0029 3a05 1904
0x0000020: 2d07 b600 2db2 0033 2db6 0037 5719 04bb
0x0000030: 0007 5912 3819 052c 1bb7 003b 03b6 002d
0x0000040: 1905 b600 3fb0
Caused by: java.lang.VerifyError: Bad type on operand stack
Exception Details:
Location:
org/bukkit/craftbukkit/util/Commodore.convert([BZLjava/lang/String;)[B @34: invokevirtual
Reason:
Type 'org/objectweb/asm/tree/ClassNode' (current frame, stack[1]) is not assignable to 'org/objectweb/asm/ClassVisitor'
Current Frame:
bci: @34
flags: { }
locals: { '[B', integer, 'java/lang/String', 'org/objectweb/asm/tree/ClassNode', 'org/objectweb/asm/ClassReader', 'org/objectweb/asm/ClassWriter' }
stack: { 'org/objectweb/asm/ClassReader', 'org/objectweb/asm/tree/ClassNode', integer }
Bytecode:
0x0000000: bb00 1e59 b700 1f4e bb00 2159 2ab7 0024
0x0000010: 3a04 bb00 2659 1904 03b7 0029 3a05 1904
0x0000020: 2d07 b600 2db2 0033 2db6 0037 5719 04bb
0x0000030: 0007 5912 3819 052c 1bb7 003b 03b6 002d
0x0000040: 1905 b600 3fb0
The text was updated successfully, but these errors were encountered: