Hi nice work on gas :) Just changed the DOM-Ready to work in strict ECMA5 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove arguments.callee since it is deprecated
|
Thanks @timse I'll try to merge that into the develop branch later this week. |
eduardocereto
added a commit
that referenced
this pull request
Jul 9, 2012
Changed the DOM-Ready to work in strict ECMA5
|
I merged this one even though I'm not so sure if I should. It won't work on iE6. What's more important, make it run on strict mode or support iE6? |
|
wasnt aware it would break ie6 my tests on ie6 did pass, where did you get a problem? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove arguments.callee since it is deprecated