Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Hi nice work on gas :) Just changed the DOM-Ready to work in strict ECMA5 #26

Merged
merged 1 commit into from

2 participants

@timse

Remove arguments.callee since it is deprecated

@timse timse remove arguments.callee
Remove arguments.callee since it is deprecated
0279dcb
@eduardocereto

Thanks @timse

I'll try to merge that into the develop branch later this week.

@eduardocereto eduardocereto merged commit 43d8b29 into CardinalPath:master
@eduardocereto

I merged this one even though I'm not so sure if I should. It won't work on iE6. What's more important, make it run on strict mode or support iE6?

@timse

wasnt aware it would break ie6 my tests on ie6 did pass, where did you get a problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jun 20, 2012
  1. @timse

    remove arguments.callee

    timse authored
    Remove arguments.callee since it is deprecated
This page is out of date. Refresh to see the latest.
Showing with 6 additions and 5 deletions.
  1. +6 −5 src/helpers.js
View
11 src/helpers.js
@@ -157,13 +157,14 @@ GasHelper.prototype._liveEvent = function(tag, evt, ofunc) {
*/
GasHelper.prototype._DOMReady = function(callback) {
var scp = this;
- var cb = function() {
- if (arguments.callee.done) return;
- arguments.callee.done = true;
- callback.apply(scp, arguments);
- };
if (/^(interactive|complete)/.test(document.readyState)) return cb();
this._addEventListener(document, 'DOMContentLoaded', cb, false);
this._addEventListener(window, 'load', cb, false);
+
+ function cb() {
+ if (cb.done) return;
+ cb.done = true;
+ callback.apply(scp, arguments);
+ }
};
Something went wrong with that request. Please try again.