Hi nice work on gas :) Just changed the DOM-Ready to work in strict ECMA5 #26

Merged
merged 1 commit into from Jul 9, 2012

Conversation

Projects
None yet
2 participants
@timse
Contributor

timse commented Jun 20, 2012

Remove arguments.callee since it is deprecated

remove arguments.callee
Remove arguments.callee since it is deprecated
@eduardocereto

This comment has been minimized.

Show comment Hide comment
@eduardocereto

eduardocereto Jun 21, 2012

Contributor

Thanks @timse

I'll try to merge that into the develop branch later this week.

Contributor

eduardocereto commented Jun 21, 2012

Thanks @timse

I'll try to merge that into the develop branch later this week.

eduardocereto added a commit that referenced this pull request Jul 9, 2012

Merge pull request #26 from timse/master
Changed the DOM-Ready to work in strict ECMA5

@eduardocereto eduardocereto merged commit 43d8b29 into CardinalPath:master Jul 9, 2012

@eduardocereto

This comment has been minimized.

Show comment Hide comment
@eduardocereto

eduardocereto Jul 9, 2012

Contributor

I merged this one even though I'm not so sure if I should. It won't work on iE6. What's more important, make it run on strict mode or support iE6?

Contributor

eduardocereto commented Jul 9, 2012

I merged this one even though I'm not so sure if I should. It won't work on iE6. What's more important, make it run on strict mode or support iE6?

@timse

This comment has been minimized.

Show comment Hide comment
@timse

timse Jul 10, 2012

Contributor

wasnt aware it would break ie6 my tests on ie6 did pass, where did you get a problem?

Contributor

timse commented Jul 10, 2012

wasnt aware it would break ie6 my tests on ie6 did pass, where did you get a problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment