Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add similar API to the Atomic Transaction Composer #131

Closed
jasonboukheir opened this issue Apr 3, 2022 · 2 comments
Closed

Add similar API to the Atomic Transaction Composer #131

jasonboukheir opened this issue Apr 3, 2022 · 2 comments
Assignees
@jasonboukheir
Labels
released on @pre

Comments

@jasonboukheir
Copy link
Member

jasonboukheir commented Apr 3, 2022 •
edited
Loading

https://developer.algorand.org/docs/get-details/atc/
@jasonboukheir jasonboukheir self-assigned this Apr 3, 2022
@jasonboukheir
Copy link
Member Author

This is related to #132 , because it's possible to enforce the specs outlined in Algorand ABI through the Atomic Transaction Composer.

@jasonboukheir jasonboukheir mentioned this issue Apr 3, 2022
Closed
jasonboukheir added a commit that referenced this issue Apr 3, 2022
@jasonboukheir
feat(signer): update ISigner interface to be closer to signer inter…
bdfc594 
…face in other SDKs

See
https://github.com/algorand/py-algorand-sdk/blob/aba9f4ccf87d4e7f7d5d6d4826e38463b76da9b8/algosdk/atomic_transaction_composer.py#L558
for an example.

BREAKING CHANGE: Remove `ISigner` interfaces from `AlgoSdk.Account` and completely change the signer
API.

re #131
jasonboukheir added a commit that referenced this issue Apr 12, 2022
@jasonboukheir
feat(atomic-txn): add APIs for building, signing, and serializing Ato…
722b7da 
…mic Txns

Start the process for creating an Atomic Txn with `Transaction.Atomic` API. TransactionGroup APIs
are now obsolete.

fix #131
jasonboukheir added a commit that referenced this issue Apr 12, 2022
@jasonboukheir
feat(signer): update ISigner interface to be closer to signer inter…
a8fbe0b 
…face in other SDKs

See
https://github.com/algorand/py-algorand-sdk/blob/aba9f4ccf87d4e7f7d5d6d4826e38463b76da9b8/algosdk/atomic_transaction_composer.py#L558
for an example.

BREAKING CHANGE: Remove `ISigner` interfaces from `AlgoSdk.Account` and completely change the signer
API.

re #131
github-actions bot pushed a commit that referenced this issue Apr 12, 2022
@semantic-release-bot
chore(release): 3.0.0-pre.2 [skip ci]
d9c8beb 
# [3.0.0-pre.2](v3.0.0-pre.1...v3.0.0-pre.2) (2022-04-12)

### Features

* **atomic-txn:** add APIs for building, signing, and serializing Atomic Txns ([858ff9e](858ff9e)), closes [#131](#131)
* **signer:** update `ISigner` interface to be closer to signer interface in other SDKs ([a8fbe0b](a8fbe0b)), closes [/github.com/algorand/py-algorand-sdk/blob/aba9f4ccf87d4e7f7d5d6d4826e38463b76da9b8/algosdk/atomic_transaction_composer.py#L558](https://github.com//github.com/algorand/py-algorand-sdk/blob/aba9f4ccf87d4e7f7d5d6d4826e38463b76da9b8/algosdk/atomic_transaction_composer.py/issues/L558) [#131](#131)

### BREAKING CHANGES

* **signer:** Remove `ISigner` interfaces from `AlgoSdk.Account` and completely change the signer
API.
@github-actions
Copy link

🎉 This issue has been resolved in version 3.0.0-pre.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Jul 16, 2022
@semantic-release-bot
chore(release): 3.0.0 [skip ci]
d672c0d 
# [3.0.0](v2.3.0...v3.0.0) (2022-07-16)

### Bug Fixes

* **abi:** fix Tuple not encoding dynamic types correctly ([be125d3](be125d3))
* **algod:** fix `AlgodClient.WaitForConfirmation` not using correct wait time ([169be0b](169be0b))
* **collections:** fix obsolete API in most recent Unity Collections package ([cf05ec9](cf05ec9))
* **inspector:** fix gaps between label and property in custom property drawers ([2ad65da](2ad65da))
* **json:** fix `JsonReader.ReadNumber` for integers when given fraction with exponent ([8bf0758](8bf0758))
* **json:** fix strings failing to be read on `null` ([dac58b7](dac58b7))
* **kmd:** fix `KmdAccount` not renewing wallet handle tokens correctly ([1b0479d](1b0479d))
* **lowlevel:** fix `NativeListOfList` not correctly assigning indices with `IIndexable<>` types ([aaa3b15](aaa3b15))
* **msgpack:** fix MessagePackWriter.Bytes issue when writing empty byte array ([eef81de](eef81de))
* **walletconnect:** `WalletConnectAccount.SignTxns` can now be done without calling `BeginSession` ([84bcba9](84bcba9))
* **walletconnect:** add checks to `AlgorandWalletConnectSession(SessionData)` ([7d0397d](7d0397d))
* **walletconnect:** fix `WalletConnectAccount` failing to assign Key for new session ([ccfd6db](ccfd6db))
* **walletconnect:** fix `WalletConnectRpc.GetRandomId` throwing error when not in main thread ([133fbd6](133fbd6))
* **walletconnect:** fix deep linking in iOS ([997ad45](997ad45))
* **walletconnect:** fix null reference err in `JsonRpcClient` ([72f8f1f](72f8f1f))
* **walletconnect:** fix null reference in `WebSocketExtensions` ([6f23d10](6f23d10))
* **walletconnect:** fix random id range and parsing ([c35e2ed](c35e2ed))
* **webgl:** fix webgl errors being caused in player test builds ([f7ee641](f7ee641))

### Code Refactoring

* **abi:** mark ABI as Experimental ([86f2c25](86f2c25))
* **editor:** move editor-specific utilities and windows to new sample ([a345cc2](a345cc2))

### Features

* **abi:** add `ArgsArray`, making it easy to pass in `IAbiValue` params to AtomicTxn Builder ([523d765](523d765))
* **abi:** add `Decode` methods to ABI ([a83f1fe](a83f1fe))
* **abi:** add ABI support ([d43eed7](d43eed7)), closes [#132](#132)
* **abi:** add abitype inspectors ([a48d710](a48d710))
* **abi:** add APIs to better create Tuples from ArgsArray ([5a109ed](5a109ed))
* **account:** add `IsAddressString` to `Address` ([a908586](a908586))
* **accounts:** add `MinBalance` constructor that takes an `AlgoSdk.Indexer.Account` result ([03dc71a](03dc71a))
* **algoapi:** create separate types for REST APIs and SDK ([#129](#129)) ([0a97a11](0a97a11)), closes [#120](#120)
* **algod:** add `Account` property to `Algod.AccountResponse` ([416685b](416685b))
* **algod:** add latest algod client features ([8873de7](8873de7))
* **algod:** add utility method `AlgodClient.WaitForConfirmation` to wait for Txn confirmation ([1e60a2d](1e60a2d))
* **api:** add `AlgoApiException` that can be thrown from an `ErrorResponse` ([2eb8209](2eb8209))
* **api:** update `AlgoApiRequest.Sent` to be convertible to UniTask ([522d4c7](522d4c7))
* **atomic-txn:** add APIs for building, signing, and serializing Atomic Txns ([858ff9e](858ff9e)), closes [#131](#131)
* **atomictxn:** add submitted and confirmed workflow to atomic transactions ([dd59ae6](dd59ae6))
* **blockchain:** add `AlgorandNetwork` enum for describing the different networks ([52594e6](52594e6))
* **endianness:** add new `FromBytesBigEndian` methods ([2623f43](2623f43))
* **signer:** update `ISigner` interface to be closer to signer interface in other SDKs ([a8fbe0b](a8fbe0b)), closes [/github.com/algorand/py-algorand-sdk/blob/aba9f4ccf87d4e7f7d5d6d4826e38463b76da9b8/algosdk/atomic_transaction_composer.py#L558](https://github.com//github.com/algorand/py-algorand-sdk/blob/aba9f4ccf87d4e7f7d5d6d4826e38463b76da9b8/algosdk/atomic_transaction_composer.py/issues/L558) [#131](#131)
* **transaction:** add `SignWith` and `SignWithAsync` API to `ITransaction` ([81aa758](81aa758))
* **util:** add `Optional<T>.Else` method ([2d6c26a](2d6c26a))
* **walletconnect:** add `SessionData.Reinitialize` method ([0d172ac](0d172ac))
* **walletconnect:** add wallet connect support to UnityEditor ([#143](#143)) ([60c13af](60c13af))
* **walletconnect:** expose `FormatUrlForDeepLink` API ([f26a7fd](f26a7fd))
* **walletconnect:** expose `SessionData.GenKey` API ([6630652](6630652))
* **walletconnect:** support chain ids in ARC-0025 ([32c518e](32c518e))

### BREAKING CHANGES

* **abi:** `AlgoSdk.Abi` renamed to `AlgoSdk.Experimental.Abi`
* **editor:** Moved all `ScriptableObject` implementations to the `AssetCreation` sample.
* **walletconnect:** `AlgorandWalletConnectSession` flow has been changed to reflect new `JsonRpcClient`.
- `StartConnection` renamed to `Connect`
- `Disconnect` renamed to `DisconnectWallet`
- `WaitForConnectionApproval` renamed to `WaitForWalletApproval`
- `SavedSession` renamed to `SessionData`
* **signer:** Remove `ISigner` interfaces from `AlgoSdk.Account` and completely change the signer
API.
* **algoapi:** All APIs and return types from `AlgodClient`, `IndexerClient`, and `KmdClient` have changed. Additional breaking changes:
- `MinBalance(AccountInfo)` constructor has changed to take an `AlgoSdk.Algod.Account` value instead.
- Remove `PrivateKey.SignTransaction`
- Rename `AppEvalDelta` -> `EvalDelta`
- Rename `AppStateDelta` -> `StateDelta`
- Rename `EvalDelta` -> `ValueDelta`
- Rename `EvalDeltaKeyValue` -> `ValueDeltaKeyValue`
- Remove readonly fields from all Transaction types.
- Rename `Multisig` -> `MultisigSig`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonboukheir jasonboukheir

Labels
released on @pre
Projects
Unity Algorand SDK
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jasonboukheir