-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asthma: Spanish Translations #233
Conversation
I've only looked a little bit at some of storybook's underlying setup functionality - but the addition of that language toggle feels like something that we could configure to show up automagically somehow? Like some of the stuff you did with the dark mode/light mode toggle - this is a pattern we want to better establish for our Stories - but it would be nice if we could do it without having to copy/paste boilerplate. |
Yeah, I agree, it would be nice to have a few of those common control types baked in. I'm not really sure how to do that. I suspect that it will involve the use of some third party storybook plugin(s) to make it happen, but it is something we can explore. Also, even if we can do that, I'm not sure it will eliminate all the boilerplate, since you'll still need to define the appropriate fields on your args/props interfaces and specify the default values in the args config for each story, but at least we wouldn't need to re-define the argTypes over and over again if we can find a way to reuse those. |
Planning to merge this later today if there are no objections or requests for delay. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. MDH-ViewBuilder uses a global switch for language, it would be nice if that could be used in MDH-UI as well at some point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Echoing the desire for this to be at a higher level. lg otherwise
83ac7f7
to
1f7a825
Compare
1f7a825
to
19155c9
Compare
Special thanks to @brandoncharnesky for figuring out a global language picker setup. I have removed the boilerplate code from each of the stories. |
Overview
This branch finishes adding Spanish language support to the Asthma components. All translations were created using ChatGPT. I also added a language toggle to each of the Asthma component stories for easier testing via the Storybook.
The provider report component remains English-only for the time being. We haven't decided yet whether that should support Spanish as well.
Security
REMINDER: All file contents are public.
Describe briefly what security risks you considered, why they don't apply, or how they've been mitigated.
Checklist
Testing
Documentation