Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Blood Pressure Visualization bottom right cube should show Min Systolic #250

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

reneefromhold
Copy link
Collaborator

Overview

Create a blood pressure survey and submit the following multiple entries for a single day (systolic/diastolic)

  1. 80/60
  2. 120/80
  3. 40/40
  4. 20/40

Current Behavior
The bottom right cube shows Lowest Diastolic with a value of 40
All other aggregate values are correct

Expected Behavior
The bottom right cube shows the Lowest Systolic with a value of 20
All other aggregate values are correct

Security

REMINDER: All file contents are public.

  • [x ] I have ensured no secure credentials or sensitive information remain in code, metadata, comments, etc.
    • [ x] Please verify that you double checked that .storybook/preview.js does not contain your participant access key details.
    • [x ] There are no temporary testing changes committed such as API base URLs, access tokens, print/log statements, etc.
  • [x ] These changes do not introduce any security risks, or any such risks have been properly mitigated.

Describe briefly what security risks you considered, why they don't apply, or how they've been mitigated.

Checklist

Testing

Documentation

  • I have added relevant Storybook updates to this PR as well.
  • If this feature requires a developer doc update, tag @CareEvolution/api-docs.

Consider "Squash and merge" as needed to keep the commit history reasonable on main.

Reviewers

@felideon

Assign to the appropriate reviewer(s). Minimally, a second set of eyes is needed ensure no non-public information is published. Consider also including:

  • Subject-matter experts
  • Style/editing reviewers
  • Others requested by the content owner

Copy link
Contributor

@brandoncharnesky brandoncharnesky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to only track the min/max systolic values.

Is there a use case for tracking Diastolic as well, or is this standard?

Looked like some language translations got dropped, looked good otherwise

🚢

@@ -149,7 +149,6 @@ let strings: { [key: string]: string } = {
"systolic-average": "Durchschnittlicher systolischer Blutdruck",
"diastolic-average": "Durchschnittlicher diastolischer Blutdruck",
"highest-systolic": "Höchster systolischer Blutdruck",
"lowest-diastolic": "Niedrigster diastolischer Blutdruck",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update these instead of deleting?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brandoncharnesky The bp viz was the only place consuming this translation.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found the spanish translation file was missing all BP labels. Updated to include those

@reneefromhold reneefromhold merged commit 89ae544 into main Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants