feat(ranks): implement ranks update

CarlosPavajeau · Nov 5, 2021 · aee511b · aee511b
1 parent 83dad59
commit aee511b
Show file tree

Hide file tree

Showing 10 changed files with 162 additions and 0 deletions.
diff --git a/src/Armory.Api/Controllers/Ranks/RanksController.cs b/src/Armory.Api/Controllers/Ranks/RanksController.cs
@@ -5,6 +5,8 @@
 using Armory.Ranks.Application.Create;
 using Armory.Ranks.Application.Find;
 using Armory.Ranks.Application.SearchAll;
+using Armory.Ranks.Application.Update;
+using Armory.Ranks.Domain;
 using AutoMapper;
 using MediatR;
 using Microsoft.AspNetCore.Authorization;
@@ -68,5 +70,21 @@ public async Task<ActionResult<RankResponse>> GetRank(int id)
 
             return RankNotFound(id);
         }
+
+        [HttpGet("{id:int}")]
+        public async Task<ActionResult> UpdateRank(int id, [FromBody] UpdateRankRequest request)
+        {
+            try
+            {
+                var command = _mapper.Map<UpdateRankCommand>(request);
+                await _mediator.Send(command);
+            }
+            catch (RankNotFoundException)
+            {
+                return RankNotFound(id);
+            }
+
+            return Ok();
+        }
     }
 }
diff --git a/src/Armory.Api/Controllers/Ranks/Requests/UpdateRankRequest.cs b/src/Armory.Api/Controllers/Ranks/Requests/UpdateRankRequest.cs
@@ -0,0 +1,8 @@
+namespace Armory.Api.Controllers.Ranks.Requests
+{
+    public class UpdateRankRequest
+    {
+        public int Id { get; set; }
+        public string Name { get; set; }
+    }
+}
diff --git a/src/Armory.Api/Controllers/Ranks/Validators/UpdateRankRequestValidator.cs b/src/Armory.Api/Controllers/Ranks/Validators/UpdateRankRequestValidator.cs
@@ -0,0 +1,20 @@
+using Armory.Api.Controllers.Ranks.Requests;
+using FluentValidation;
+
+namespace Armory.Api.Controllers.Ranks.Validators
+{
+    public class UpdateRankRequestValidator : AbstractValidator<UpdateRankRequest>
+    {
+        public UpdateRankRequestValidator()
+        {
+            RuleFor(m => m.Id)
+                .NotNull();
+
+            RuleFor(m => m.Name)
+                .NotNull()
+                .NotEmpty()
+                .MaximumLength(256)
+                .WithName("Nombre");
+        }
+    }
+}
diff --git a/src/Armory.Api/Extensions/DependencyInjection/Ranks/RanksApplication.cs b/src/Armory.Api/Extensions/DependencyInjection/Ranks/RanksApplication.cs
@@ -1,6 +1,7 @@
 using Armory.Ranks.Application.Create;
 using Armory.Ranks.Application.Find;
 using Armory.Ranks.Application.SearchAll;
+using Armory.Ranks.Application.Update;
 using Microsoft.Extensions.DependencyInjection;
 
 namespace Armory.Api.Extensions.DependencyInjection.Ranks
@@ -12,6 +13,7 @@ public static IServiceCollection AddRanksApplication(this IServiceCollection ser
             services.AddScoped<RankCreator, RankCreator>();
             services.AddScoped<RankFinder, RankFinder>();
             services.AddScoped<AllRanksSearcher, AllRanksSearcher>();
+            services.AddScoped<RankUpdater, RankUpdater>();
 
             return services;
         }

diff --git a/src/Armory.Api/Profiles/RanksProfile.cs b/src/Armory.Api/Profiles/RanksProfile.cs
@@ -1,5 +1,6 @@
 using Armory.Api.Controllers.Ranks.Requests;
 using Armory.Ranks.Application.Create;
+using Armory.Ranks.Application.Update;
 using AutoMapper;
 
 namespace Armory.Api.Profiles
@@ -9,6 +10,7 @@ public class RanksProfile : Profile
         public RanksProfile()
         {
             CreateMap<CreateRankRequest, CreateRankCommand>();
+            CreateMap<UpdateRankRequest, UpdateRankCommand>();
         }
     }
 }
diff --git a/src/Armory/Ranks/Application/Update/RankUpdater.cs b/src/Armory/Ranks/Application/Update/RankUpdater.cs
@@ -0,0 +1,22 @@
+using System.Threading.Tasks;
+using Armory.Ranks.Domain;
+using Armory.Shared.Domain.Persistence.EntityFramework;
+
+namespace Armory.Ranks.Application.Update
+{
+    public class RankUpdater
+    {
+        private readonly IUnitWork _unitWork;
+
+        public RankUpdater(IUnitWork unitWork)
+        {
+            _unitWork = unitWork;
+        }
+
+        public async Task Update(Rank rank, string newName)
+        {
+            rank.Name = newName;
+            await _unitWork.SaveChanges();
+        }
+    }
+}
diff --git a/src/Armory/Ranks/Application/Update/UpdateRankCommand.cs b/src/Armory/Ranks/Application/Update/UpdateRankCommand.cs
@@ -0,0 +1,10 @@
+using Armory.Shared.Domain.Bus.Command;
+
+namespace Armory.Ranks.Application.Update
+{
+    public class UpdateRankCommand : Command
+    {
+        public int Id { get; init; }
+        public string Name { get; init; }
+    }
+}
diff --git a/src/Armory/Ranks/Application/Update/UpdateRankCommandHandler.cs b/src/Armory/Ranks/Application/Update/UpdateRankCommandHandler.cs
@@ -0,0 +1,31 @@
+using System.Threading;
+using System.Threading.Tasks;
+using Armory.Ranks.Application.Find;
+using Armory.Ranks.Domain;
+using Armory.Shared.Domain.Bus.Command;
+
+namespace Armory.Ranks.Application.Update
+{
+    public class UpdateRankCommandHandler : CommandHandler<UpdateRankCommand>
+    {
+        private readonly RankFinder _finder;
+        private readonly RankUpdater _updater;
+
+        public UpdateRankCommandHandler(RankFinder finder, RankUpdater updater)
+        {
+            _finder = finder;
+            _updater = updater;
+        }
+
+        protected override async Task Handle(UpdateRankCommand request, CancellationToken cancellationToken)
+        {
+            var rank = await _finder.Find(request.Id);
+            if (rank is null)
+            {
+                throw new RankNotFoundException();
+            }
+
+            await _updater.Update(rank, request.Name);
+        }
+    }
+}
diff --git a/src/Armory/Ranks/Domain/RankNotFoundException.cs b/src/Armory/Ranks/Domain/RankNotFoundException.cs
@@ -0,0 +1,11 @@
+using Armory.Shared.Domain;
+
+namespace Armory.Ranks.Domain
+{
+    /// <summary>
+    ///     Represents errors that occur when rank is not found
+    /// </summary>
+    public class RankNotFoundException : ArmoryException
+    {
+    }
+}
diff --git a/test/Armory.Api.Test/Controllers/Ranks/RanksControllerTest.cs b/test/Armory.Api.Test/Controllers/Ranks/RanksControllerTest.cs
@@ -8,7 +8,11 @@
 using Armory.Ranks.Application.Create;
 using Armory.Ranks.Application.Find;
 using Armory.Ranks.Application.SearchAll;
+using Armory.Ranks.Application.Update;
+using Armory.Ranks.Domain;
 using AutoMapper;
+using FluentAssertions;
+using MediatR;
 using Microsoft.AspNetCore.Mvc;
 using Microsoft.EntityFrameworkCore;
 using Microsoft.Extensions.DependencyInjection;
@@ -117,5 +121,39 @@ public async Task Get_A_Non_Existent_Rank()
             Assert.IsTrue(errors.Any());
             Assert.AreEqual("No se encontró ningun rango con el código '2'.", errors[0]);
         }
+
+        [Test]
+        [Order(6)]
+        public async Task UpdateRank_ShouldUpdateRank()
+        {
+            Mediator.Setup(x => x.Send(It.IsAny<UpdateRankCommand>(), CancellationToken.None))
+                .ReturnsAsync((UpdateRankCommand command, CancellationToken _) =>
+                    command.Id == 1 ? Unit.Value : throw new RankNotFoundException());
+
+            var request = new UpdateRankRequest
+            {
+                Id = 1,
+                Name = "Estudiante"
+            };
+
+            var result = await _controller.UpdateRank(request.Id, request);
+
+            result.Should().NotBeNull().And.BeAssignableTo<OkResult>();
+        }
+
+        [Test]
+        [Order(7)]
+        public async Task UpdateRank_ShouldReturnNotFound()
+        {
+            var request = new UpdateRankRequest
+            {
+                Id = 2,
+                Name = "Estudiante"
+            };
+
+            var result = await _controller.UpdateRank(request.Id, request);
+
+            result.Should().NotBeNull().And.BeAssignableTo<NotFoundObjectResult>();
+        }
     }
 }