Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submodules of dependencies aren't checked out correctly #67

Closed
jspahrsummers opened this issue Nov 13, 2014 · 2 comments · Fixed by #69
Closed

Submodules of dependencies aren't checked out correctly #67

jspahrsummers opened this issue Nov 13, 2014 · 2 comments · Fixed by #69
Assignees
@jspahrsummers
Labels
bug
Milestone
Public Release

Comments

@jspahrsummers
Copy link
Member

Discovered while testing #57. git clone --recursive doesn't do anything with bare repos, and git checkout (rightly) won't automatically update submodules.

Since the .gitmodules file is checked out to something that's not the top-level, git submodule init doesn't even work. We'll need to do something better.
@jspahrsummers jspahrsummers self-assigned this Nov 13, 2014
@jspahrsummers jspahrsummers added this to the Initial Release milestone Nov 13, 2014
@jspahrsummers jspahrsummers removed their assignment Nov 13, 2014
@jspahrsummers
Copy link
Member Author

Maybe an acceptable answer for 0.1 is “submodules of dependencies not supported, use a Cartfile instead?” Although I would dearly love to fix this if there's an easy way. 😕

@jspahrsummers
Copy link
Member Author

NB: .gitmodules can be parsed with git config -f .gitmodules --list.

@jspahrsummers jspahrsummers self-assigned this Nov 14, 2014
@jspahrsummers jspahrsummers mentioned this issue Nov 14, 2014
Merged
1 task
natanrolnik pushed a commit to natanrolnik/Carthage that referenced this issue Feb 2, 2017
@mdiep
Merge pull request Carthage#67 from Carthage/update-quick
ca373d4 
Update Quick to v0.9.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jspahrsummers jspahrsummers

Labels
bug
Projects
None yet
Milestone
Public Release
Development

Successfully merging a pull request may close this issue.

Automatically checkout dependencies' submodules Carthage/Carthage
1 participant
@jspahrsummers