Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

carthage update #57

Merged
merged 22 commits into from Nov 14, 2014
Merged

carthage update #57

merged 22 commits into from Nov 14, 2014

Conversation

jspahrsummers
Copy link
Member

Resolves #40.

To do:

  • Check out dependencies after resolution
  • Write resolved Cartfile.lock
  • Build dependencies
  • Serialize fetching and cloning, or fix the overlapping output
  • Move Git invocations into Git.swift
  • Wrap updating logic in a type, including the project-to-version cache

@jspahrsummers jspahrsummers added this to the Initial Release milestone Nov 13, 2014
@jspahrsummers
Copy link
Member Author

The basics of this are working (but there's still a lot to do, so it's not ready for review yet):

justin:Carthage/ (git)-[carthage-update] $ carthage update
*** Cloning ReactiveCocoa
*** Cloning LlamaKit
*** Cloning Quick
*** Cloning xcconfigs
*** Cloning Nimble
…

justin:Carthage/ (git)-[carthage-update] $ cat Cartfile.lock
github "Carthage/Quick" "carthage-0.2"
github "Carthage/LlamaKit" "llamakit-0.1"
github "Carthage/xcconfigs" "carthage-0.6"
github "Carthage/ReactiveCocoa" "carthage-3.0"
github "Carthage/Nimble" "carthage-0.1"

justin:Carthage/ (git)-[carthage-update] $ echo 'github "jspahrsummers/objc-build-scripts"' >> Cartfile
justin:Carthage/ (git)-[carthage-update] $ carthage update
*** Fetching ReactiveCocoa
*** Fetching LlamaKit
*** Fetching Quick
*** Fetching xcconfigs
*** Fetching Nimble
*** Cloning objc-build-scripts
…

justin:Carthage/ (git)-[carthage-update] $ cat Cartfile.lock
github "jspahrsummers/objc-build-scripts" "0.1.1"
github "Carthage/Quick" "carthage-0.2"
github "Carthage/LlamaKit" "llamakit-0.1"
github "Carthage/xcconfigs" "carthage-0.6"
github "Carthage/ReactiveCocoa" "carthage-3.0"
github "Carthage/Nimble" "carthage-0.1"

@jspahrsummers jspahrsummers changed the title [WIP] carthage update carthage update Nov 13, 2014
@jspahrsummers
Copy link
Member Author

This is ready for review. I punted on integrating it with carthage build just yet, so it's just the cloning/fetching and checkout bits right now.

Carthage/ (git)-[carthage-update] $ carthage update
*** Fetching ReactiveCocoa
*** Cloning LlamaKit
*** Fetching Quick
*** Cloning xcconfigs
*** Fetching Nimble
*** Checking out Quick at "carthage-0.2"
*** Checking out LlamaKit at "llamakit-0.1"
*** Checking out xcconfigs at "carthage-0.6"
*** Checking out ReactiveCocoa at "carthage-3.0"
*** Checking out Nimble at "carthage-0.1"

This was referenced Nov 13, 2014
Merged
Closed
mdiep
mdiep reviewed Nov 14, 2014
View reviewed changes
Carthage/Update.swift
public let function = "Clone, check out, and build the dependencies in the project's Cartfile"

public func run(mode: CommandMode) -> Result<()> {
let directoryURL = NSURL.fileURLWithPath(NSFileManager.defaultManager().currentDirectoryPath)!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like we should pass this in since it's useful for most commands.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's #66, addressed in #65.

@jspahrsummers
Copy link
Member Author

@mdiep
Copy link
Member

mdiep commented Nov 14, 2014

👍 I skimmed most of this, but it seems fine as a first attempt.

jspahrsummers added a commit that referenced this pull request Nov 14, 2014
@jspahrsummers
Merge pull request #57 from Carthage/carthage-update
8f97455 
carthage update
@jspahrsummers jspahrsummers merged commit 8f97455 into master Nov 14, 2014
@jspahrsummers jspahrsummers deleted the carthage-update branch November 14, 2014 18:56
hujunfeng pushed a commit to hujunfeng/Carthage that referenced this pull request Oct 30, 2021
@werner77
Merge pull request Carthage#57 from ffittschen/bugfix/tar-binaries
8c7e16a 
Add support for tar binaries in BinaryProjectCache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Public Release
Development

Successfully merging this pull request may close these issues.

carthage update
2 participants
@jspahrsummers @mdiep