Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2400 Shared cache for built dependencies #2716

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@kenji21
Copy link
Contributor

kenji21 commented Mar 1, 2019

see discussion in issue #2400

@nikolaeu

This comment has been minimized.

Copy link

nikolaeu commented Mar 3, 2019

Nice one @kenji21! How about some details in readme.md?

@blender

This comment has been minimized.

Copy link
Member

blender commented Mar 4, 2019

LGTM.

My only concern is that this would be enabled by default.

How does @Carthage/carthage feel about it?

@blender blender self-requested a review Mar 4, 2019

@blender

blender approved these changes Mar 4, 2019

@jdhealy jdhealy self-requested a review Mar 4, 2019

@killobatt

This comment has been minimized.

Copy link

killobatt commented Mar 5, 2019

Hello. Merging of this PR can reduce our clean/build time from 22minutes to 5-6 minutes, our team really waits for it.
It there something we can do to help it be merged faster?

@joshuapoq

This comment has been minimized.

Copy link

joshuapoq commented Mar 5, 2019

For clarity, (as I understand it) this allows Carthage to share already built dependencies across projects.

We have a workspace that has Y many targets across many projects that all depend downwards on X number of common lower level targets. Am I correct in thinking this will now only build all X of these common frameworks once instead of X * Y times?

@kenji21

This comment has been minimized.

Copy link
Contributor Author

kenji21 commented Mar 6, 2019

For clarity, (as I understand it) this allows Carthage to share already built dependencies across projects.

We have a workspace that has Y many targets across many projects that all depend downwards on X number of common lower level targets. Am I correct in thinking this will now only build all X of these common frameworks once instead of X * Y times?

That's the point, here is how @blender nicely recap it : #2400 (comment)

@mdiep mdiep self-requested a review Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.