Reject invalid archives - Fix #2791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x/issue-2764-reject-invalid-archives
tmspzz
force-pushed
the
fix/issue-2764-reject-invalid-archives
branch
from
45c8ac8
to
7653413
Compare
ffittschen
reviewed
May 17, 2019
Co-Authored-By: Florian Fittschen <ffittschen@gmail.com>
ffittschen
approved these changes
May 17, 2019
There was a problem hiding this comment.
I just built carthage using this branch and can confirm that the fix resolves the issue that I reported earlier #2765 (comment)
Thanks for the quick follow-up!
|
It definitely doesn't resolve #2777. Only the intermediate issue I reported in #2765 (comment) I added steps to reproduce to the original issue: #2777 (comment) |
mdiep
approved these changes
May 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes inverted parameters in source and destination. Noticed by @ffittschen