Adds support to configure the GitHub access token to be used for GitHub API calls #605

guidomb · 2015-07-07T20:33:11Z

fixes #603

To avoid Github rate limit issues now it is possible
to provide a Github API access token.

In shared environment where several virtual machines
are using the same public ip address (like travis ci),
carthage user could hit a Github API rate limit. By
providing a Github API access token, carthage can get
a higher rate limit.

To avoid Github rate limit issues now it is possible to provide a Github API access token. In shared environment where several virtual machines are using the same public ip address (like travis ci), carthage user could hit a Github API rate limit. By providing a Github API access token, carthage can get a higher rate limit.

guidomb · 2015-07-07T21:33:13Z

You can check https://github.com/Wolox/ReactiveArray to see a running version of this patch in TravisCI

mdiep · 2015-07-08T15:08:14Z

I have mixed feels about this. @Carthage/carthage?

robrix · 2015-07-08T15:35:36Z

Seems like maybe this shouldn’t be a command line argument, but maybe an environment variable?

robb · 2015-07-08T16:17:47Z

The need is real, but I agree that an environment variable is probably the way to go here.

mdiep · 2015-07-08T16:19:24Z

👍 to an environment variable.

guidomb · 2015-07-08T18:08:48Z

I will remove the command line parameter and add support for the GITHUB_ACCESS_TOKEN env variable.

I wasn't sure about adding a the githubAccessToken parameter to this and this method. It just doesn't feel right but by adding the env variable all the logic needed to decided the authentication method can be encapuslated in the Github.swift file.

Should I amend the previous commit or add a new one?

mdiep · 2015-07-08T18:17:09Z

New commits are preferred to rewriting history. 😄

guidomb · 2015-07-08T19:01:43Z

Just replaced the command line argument for the env variable. Let me know if you want to change something else.

mdiep · 2015-07-13T03:03:09Z

Source/CarthageKit/GitHub.swift

@@ -266,6 +284,14 @@ internal struct GitHubCredentials {
 	}
 }

+internal func loadGitHubCredentials(accessToken: GitHubAccessToken?) -> SignalProducer<GitHubCredentials?, CarthageError> {
+	if let accessToken = accessToken {
+		return SignalProducer(value: AccessTokenGitHubCredentials(accessToken: accessToken))


Can we read GITHUB_ACCESS_TOKEN here instead of passing it in? I think it's best to read it from CarthageKit.

Yeah we can definetly do that. My retaionale behind this was that for me the command line app is the one responsabile for obtaining the input (user or env) and feed that input to the CarthageKit lib.

mdiep · 2015-07-13T03:18:22Z

I really like where this is headed—thanks for working on it! ✨ And sorry for the delayed review.

Instead of reading the env variable in the Carthage command line application we do it inside CarthageKit.

guidomb · 2015-07-14T03:08:52Z

@mdiep I've just commited the fixes we were discussing. Let me know if there is anything else. Should I amend all the commits before merge?

ikesyo · 2015-07-14T03:13:18Z

Source/CarthageKit/GitHub.swift

@@ -11,6 +11,7 @@ import Foundation
 import Result
 import ReactiveCocoa
 import Runes
+import Box


Is this import needed?

Sorry for that I forgot to delete it. I was trying a different approch that didn't work and I left that. I am adding a new commit to fix it.

mdiep · 2015-07-14T03:17:21Z

Should I amend all the commits before merge?

No, you don't need to amend the commits. We prefer history to be unaltered.

mdiep · 2015-07-14T03:53:20Z

Thanks for all the work you put into this. It looks great! ✨

Adds support to configure the GitHub access token to be used for GitHub API calls

ikesyo · 2015-07-14T06:22:23Z

🎉

robb · 2015-08-05T16:47:39Z

@mdiep would you mind building a new release including this feature?

mdiep · 2015-08-05T21:30:40Z

@robb I'll try to do so in the next few days. I've been busy with a move, but would really like to get all the new bits out in the wild.

guidomb · 2015-08-05T21:33:05Z

@mdiep I would be nice (if possible) to have #583 in the next release too. Thanks!

mdiep · 2015-08-07T16:48:09Z

I just released 0.8: Llama Calculus. #583 didn't make it in, but I'll cut another release once the current batch of PRs is merged.

I haven't opened a PR for homebrew since I don't use it, but it'd be ✨ if someone wanted to do so.

guidomb · 2015-08-07T19:24:26Z

@mdiep To open a PR for homebrew do we need to collaborators or anybody can do it? I've never released a brew formula before.

mdiep · 2015-08-07T20:17:54Z

I think anybody, but I've never done it either. You should be able to search for Carthage in their PRs to find an example.

guidomb · 2015-08-07T20:47:35Z

Here it is https://github.com/Homebrew/homebrew/pull/42632/files

Carthage version 0.8 has been released and there is no need to use a custom build because Carthage/Carthage#605 is available now

Carthage/Carthage#605

Blackjacx · 2019-01-04T13:50:26Z

Hey any support for .env files to store the GITHUB_ACCESS_TOKEN? It feels unnecessary to do this each time we need to update our dependencies. It's better to store it in the .env file and let the carthage read this file like fastlane and many shell commands do it.

mdiep · 2019-01-06T00:33:26Z

PRs welcome :)

ikesyo · 2019-01-06T04:39:48Z

Using direnv will be a possible solution.

Blackjacx · 2019-01-06T19:40:41Z

Oh thx, that’s a great tip 👍

Replaces --github-access-token cmd option for env variable.

fbbffa1

guidomb changed the title ~~Adds --github-access-token checkout option.~~ Adds support to configure the GitHub access token to be used for GitHub API calls Jul 8, 2015

guidomb mentioned this pull request Jul 9, 2015

Remove Carthage.pkg from source control. Wolox/ReactiveArray#3

Closed

mdiep reviewed Jul 13, 2015
View reviewed changes

Guido Marucci Blas added 2 commits July 13, 2015 12:46

Reads GITHUB_ACCESS_TOKEN env variable inside CarthageKit.

2b65aed

Instead of reading the env variable in the Carthage command line application we do it inside CarthageKit.

Removes GitHubCredentials protocol and classes.

0f8daba

ikesyo reviewed Jul 14, 2015
View reviewed changes

Guido Marucci Blas added 2 commits July 14, 2015 00:18

Removes unused Box import.

ffe3626

Reverts default value for parameter withAuthorizationHeaderValue.

f34616c

mdiep added a commit that referenced this pull request Jul 14, 2015

Merge pull request #605 from guidomb/github-access-token-option

d38ddcb

Adds support to configure the GitHub access token to be used for GitHub API calls

mdiep merged commit d38ddcb into Carthage:master Jul 14, 2015

ikesyo mentioned this pull request Jul 14, 2015

Minor refactoring for optional binding #617

Merged

guidomb deleted the github-access-token-option branch July 14, 2015 17:35

mdiep mentioned this pull request Aug 4, 2015

Carthage can't download binary framework of a private repository #656

Closed

ikesyo mentioned this pull request Aug 5, 2015

Add support for GitHub Enterprise #657

Merged

ikesyo mentioned this pull request Aug 7, 2015

'carthage bootstrap' will not run on CircleCI #595

Closed

guidomb pushed a commit to guidomb/ios-scripts that referenced this pull request Aug 13, 2015

Removes the use of custom Carthage build.

d5301c5

Carthage version 0.8 has been released and there is no need to use a custom build because Carthage/Carthage#605 is available now

adamkaplan added a commit to yahoo/YMCache that referenced this pull request Sep 10, 2015

Add GITHUB_ACCESS_TOKEN for Carthage on Travis

327454e

Carthage/Carthage#605

cybertk mentioned this pull request Sep 14, 2015

GitHub API request failed: API rate limit exceeded for A.B.C.D cybertk/generator-swift-framework#10

Open

mollyIV mentioned this pull request Feb 20, 2018

Authentication methods to access private binary repository. #1783

Closed

ilammy mentioned this pull request May 13, 2021

Carthage XCF support and OpenSSL 1.1.1k cossacklabs/themis#817

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds support to configure the GitHub access token to be used for GitHub API calls #605

Adds support to configure the GitHub access token to be used for GitHub API calls #605

guidomb commented Jul 7, 2015

guidomb commented Jul 7, 2015

mdiep commented Jul 8, 2015

robrix commented Jul 8, 2015

robb commented Jul 8, 2015

mdiep commented Jul 8, 2015

guidomb commented Jul 8, 2015

mdiep commented Jul 8, 2015

guidomb commented Jul 8, 2015

mdiep Jul 13, 2015

guidomb Jul 13, 2015

mdiep commented Jul 13, 2015

guidomb commented Jul 14, 2015

ikesyo Jul 14, 2015

guidomb Jul 14, 2015

mdiep commented Jul 14, 2015

mdiep commented Jul 14, 2015

ikesyo commented Jul 14, 2015

robb commented Aug 5, 2015

mdiep commented Aug 5, 2015

guidomb commented Aug 5, 2015

mdiep commented Aug 7, 2015

guidomb commented Aug 7, 2015

mdiep commented Aug 7, 2015

guidomb commented Aug 7, 2015

Blackjacx commented Jan 4, 2019

mdiep commented Jan 6, 2019

ikesyo commented Jan 6, 2019

Blackjacx commented Jan 6, 2019

Adds support to configure the GitHub access token to be used for GitHub API calls #605

Adds support to configure the GitHub access token to be used for GitHub API calls #605

Conversation

guidomb commented Jul 7, 2015

guidomb commented Jul 7, 2015

mdiep commented Jul 8, 2015

robrix commented Jul 8, 2015

robb commented Jul 8, 2015

mdiep commented Jul 8, 2015

guidomb commented Jul 8, 2015

mdiep commented Jul 8, 2015

guidomb commented Jul 8, 2015

mdiep Jul 13, 2015

Choose a reason for hiding this comment

guidomb Jul 13, 2015

Choose a reason for hiding this comment

mdiep commented Jul 13, 2015

guidomb commented Jul 14, 2015

ikesyo Jul 14, 2015

Choose a reason for hiding this comment

guidomb Jul 14, 2015

Choose a reason for hiding this comment

mdiep commented Jul 14, 2015

mdiep commented Jul 14, 2015

ikesyo commented Jul 14, 2015

robb commented Aug 5, 2015

mdiep commented Aug 5, 2015

guidomb commented Aug 5, 2015

mdiep commented Aug 7, 2015

guidomb commented Aug 7, 2015

mdiep commented Aug 7, 2015

guidomb commented Aug 7, 2015

Blackjacx commented Jan 4, 2019

mdiep commented Jan 6, 2019

ikesyo commented Jan 6, 2019

Blackjacx commented Jan 6, 2019