Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Quick 2.0.0 Nimble 8.0.0 #141

Closed
wants to merge 3 commits into from
Closed

Update Quick 2.0.0 Nimble 8.0.0 #141

wants to merge 3 commits into from

Conversation

doozMen
Copy link
Contributor

@doozMen doozMen commented Mar 6, 2019

I also ignored the Xcode project file. Maybe this is not needed and then I can remove it.

Package.swift Outdated Show resolved Hide resolved
@norio-nomura
Copy link
Contributor

I also ignored the Xcode project file. Maybe this is not needed and then I can remove it.

AFAIK, SourceKitten and SwiftLint are still configured on the assumption that Commandant has Xcode project yet.
@jpsim @marcelofabri Can we drop Xcode project on SwiftLint and SourceKitten?

@jpsim
Copy link
Contributor

jpsim commented Mar 6, 2019

Sorry I must have missed a conversation somewhere, why is the Xcode project being removed? Seems like a useful thing to keep?

@norio-nomura
Copy link
Contributor

Seems like a useful thing to keep?

I thought so.
However, I knew that the Xcode project had already been deleted in Carthage, and I was concerned about whether there is a motivation to positively delete the Xcode project from repository. 🤔

Copy link
Member

@ikesyo ikesyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, though removing the Xcode project breaks the existing library users' builds through Carthage. So please revert that change.

And also you should update Cartfile.private and run carthage update Quick Nimble --no-build.

@norio-nomura norio-nomura mentioned this pull request Mar 7, 2019
@norio-nomura
Copy link
Contributor

I opened #142 that includes this.

@doozMen
Copy link
Contributor Author

doozMen commented Mar 7, 2019

@norio-nomura and @ikesyo I think you should not merge this branch. I have some problems with indeed AFAIK, SourceKitten and SwiftLint not yet updated to quick and nimble new breaking releases. Also removing the Xcode project seams harsh. It is more a discussion point. I used to be against it but now that the swift package manager actually generates a useful Xcode project every time (in my latest experience) I think it is dangerous to leave it as you will be tempted to change stuff in it. Maybe it could be an option, for legacy support, to move Xcode project to a subfolder as swift package manager depends on it to be in tech root folder?

@doozMen
Copy link
Contributor Author

doozMen commented Mar 7, 2019

Will you close this PR or should I do this? Thanks for the good feedback!

@norio-nomura
Copy link
Contributor

@doozMen: Sorry for confusion. 🙇
I rebased #142 to your changes and will continue on that.
Thanks for contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants