Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DB Connection Error in tests when % character in PG_PASSWORD #509

Merged

Conversation

DeanSherwin
Copy link
Contributor

Description

Shortcut

Please include a summary of the change. If required, also include relevant info about motivation and context... And if PR includes UI elements (or if it helps for understanding it), please add extra files: snapshots, videos...

Type of change

  • Fix

Acceptance

To recreate issue:

  1. Set PG_USER's password to include % character
  2. From the analytics-toolbox project, run cd clouds/postgres && make test
  3. It will fail due to a bad password in the connection_string in submodule `core/clouds/postgres/common/test_utils/init.py
  4. Checkout this branch in core and rerun. The tests should run fine

@DeanSherwin DeanSherwin self-assigned this May 13, 2024
Copy link
Member

@Jesus89 Jesus89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@DeanSherwin DeanSherwin merged commit 693cfc4 into main May 13, 2024
8 checks passed
@vdelacruzb vdelacruzb mentioned this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants