Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support hours and minutes as step size in the time series widget #297

Merged
merged 3 commits into from
Jan 26, 2022
Merged

Support hours and minutes as step size in the time series widget #297

merged 3 commits into from
Jan 26, 2022

Conversation

Clebal
Copy link
Contributor

@Clebal Clebal commented Jan 24, 2022

@Clebal Clebal added the enhancement New feature or request label Jan 24, 2022
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #198248: Support hours and minutes as step size in the time series widget.

@coveralls
Copy link
Collaborator

coveralls commented Jan 24, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1752469793

  • 3 of 8 (37.5%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 70.326%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/widgets/TimeSeriesWidgetUI/TimeSeriesWidgetUI.js 3 5 60.0%
packages/react-core/src/operations/groupByDate.js 0 3 0.0%
Totals Coverage Status
Change from base Build 1740086684: -0.09%
Covered Lines: 1157
Relevant Lines: 1550
💛 - Coveralls

VictorVelarde
VictorVelarde reviewed Jan 24, 2022
View reviewed changes
Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please add a changelog entry

Josmorsot
Josmorsot approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@Josmorsot Josmorsot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VictorVelarde VictorVelarde self-assigned this Jan 26, 2022
@VictorVelarde VictorVelarde merged commit 632bb50 into master Jan 26, 2022
@VictorVelarde VictorVelarde deleted the feature/sc-198248/support-hours-and-minutes-as-step-size-in branch January 26, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VictorVelarde VictorVelarde VictorVelarde approved these changes

@Josmorsot Josmorsot Josmorsot approved these changes

@borja-munoz borja-munoz Awaiting requested review from borja-munoz

Assignees

@VictorVelarde VictorVelarde

Labels
enhancement New feature or request widgets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Clebal @coveralls @VictorVelarde @Josmorsot