CARTO Builder activated notification always shown in account/profile pages

[javitonino]

That notification is always shown in account/profile pages (but not in the dashboard), even though it has been marked as read:

dashboardNotifications = Object { builder_activated: true }

The problem is that, in this case frontend is checking for dashboard_notifications. There is a mix of both styles in both frontend and backend, but it's not always right.

I'd encourage to standardize in a single style, because it's crazy otherwise.

cc @ramiroaznar

[VictorVelarde]

As @javitonino explained, the problem was misspelled variable names among front & back.

In both cases dashboardNotifications has to be renamed to dashboard_notifications (at /cartodb/app/views/admin/users/account.html.erb and /cartodb/app/views/admin/users/profile.html.erb)

We should have a look at other similar pages for consistency on variable naming and to avoid this kind of errors.

[VictorVelarde]

This seems to be the same issue as #12091

[rubenmoya]

In production! 🚀

[zingbot]

Nice! Thank you so much for removing this.

[alonsogarciapablo]

It looks like this is still being displayed. @ramiroaznar just reported it:

[alonsogarciapablo]

@ramiroaznar We should look into the code to understand when this is currently being displayed so that we can decide wether to keep it in some cases or remote it forever and ever.

[jsanz]

@rjimenezda any update on this issue? Should we take it out of the RT kanban?

[jesusbotella]

I've just checked this and the notification is shown in Builder, Dataset, Account, Profile, and API Keys page.

The notification has the same conditions in every page to be shown. It is checked that:

• CARTO is hosted in carto.com
• Has builder enabled
• show_builder_activated_message variable is true in user
• There are no dashboard notifications

Here's the code snippet of one of the pages:

cartodb/lib/assets/javascripts/dashboard/api-keys.js

Lines 114 to 128 in e0f947e

	if (!userModel.get('cartodb_com_hosted')) {
	if (userModel.get('actions').builder_enabled && userModel.get('show_builder_activated_message') &&
	_.isEmpty(window.dashboard_notifications)) {
	const userNotificationModel = new UserNotificationModel(window.dashboard_notifications, {
	key: 'dashboard',
	configModel: configModel
	});
	const dashboardNotification = new UserNotificationView({
	notification: userNotificationModel
	});
	window.dashboardNotification = dashboardNotification;
	}
	}

Seems like conditions are the same for all pages. We can close this issue and open a new one if we want to remove that notification.

[alonsogarciapablo]

Let's 🔥🔥🔥 the notification!

[javitonino]

Let's firefirefire the notification!

Please, if you do that, also remove the code from backend (the show_builder_activated_message part)

[jesusbotella]

Fired, merged and deployed! 🔥

[alonsogarciapablo]

Great @jesusbotella!