Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Builder enabled notification #14784

Merged
merged 8 commits into from
Mar 28, 2019

Conversation

jesusbotella
Copy link
Contributor

This Pull request removes Builder enabled notification that appears whenever a Editor user is upgraded to Builder if the user was created before Builder Launch.

It's been removed from:

  • Dashboard
    • Account page
    • API Keys page
    • Dashboard
    • Profile
  • Builder
    • Builder itself
    • Dataset page

Related to #13691

@jesusbotella
Copy link
Contributor Author

It would be great if @javitonino or someone from backend can review this PR as well because I don't know if we should remove something else from the backend part.

Copy link
Contributor

@javitonino javitonino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup! 💋

@csubira
Copy link
Contributor

csubira commented Mar 28, 2019

Acceptance done via the following steps:

  • Log in with staging user
  • Add new dataset in dashboard
  • Open dataset page
  • Create a map with new dataset
  • Open map in builder

(Check in all steps that no errors are raised)
Acceptance 🆗

@jesusbotella jesusbotella merged commit 2212dc7 into master Mar 28, 2019
@jesusbotella jesusbotella deleted the 13691-delete-builder-enabled-notification branch March 28, 2019 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants