Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update googlemaps api version to v3.32 #13902

Closed
VictorVelarde opened this issue Apr 27, 2018 · 6 comments
Closed

Update googlemaps api version to v3.32 #13902

VictorVelarde opened this issue Apr 27, 2018 · 6 comments

Comments

@VictorVelarde
Copy link
Contributor

VictorVelarde commented Apr 27, 2018

There are some internal references to googlemaps api v3.30 inside the application, that should be updated (e.g. app/views/shared/_google_maps.html.erb).

We should upgrade to the current stable version.

As a reference, we have recently updated carto.js v4 and dealed with some related issues (see for example: CartoDB/carto.js#2067)

@VictorVelarde
Copy link
Contributor Author

VictorVelarde commented May 31, 2018

From 2018/05/16, v3.32 is the stable version, so that's the update to apply inside these files

@VictorVelarde VictorVelarde changed the title Update googlemaps api version to v3.31 Update googlemaps api version to v3.32 May 31, 2018
@VictorVelarde
Copy link
Contributor Author

This should be coordinated with the update in carto.js. See CartoDB/carto.js#2126

@VictorVelarde
Copy link
Contributor Author

VictorVelarde commented Jul 6, 2018

@ivanmalagon I think we should upgrade these internal hardcoded references, once carto.js is working as expected with current gmaps stable version (v.3.32)

_google_maps.html.erb seems now to be unused (should we delete it?), but static.js is being used indeed.

I have created #14146 to deal with this update.

@ivanmalagon
Copy link
Contributor

We haven't run into any problem lately with 3.32 so... go ahead!

@VictorVelarde
Copy link
Contributor Author

@ramiroaznar this was nearly finished some days ago, could you include it in the current RT?

@VictorVelarde
Copy link
Contributor Author

Shipped to prod 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants